Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-6446] added global configurations for all the six types of unittest changes (increase or descrease of passed, failed and skipped tests) #11

Merged
merged 4 commits into from Nov 3, 2013

Conversation

@lkamal
Copy link
Contributor

commented Oct 20, 2013

Given default values are:

  • Passing test
  • added: +1
  • removed: 0
  • Failing test
  • added: -1
  • removed: 0
  • Skipped test (no marks given or reduced)
  • added: 0
  • removed: 0

The configuration is available under 'Continuous integration game - Unit Tests' section in advanced mode.

If you could review this and see whether this can be incorporated or provide more input; it will be helpful.

lkamal added 2 commits Oct 20, 2013
[FIXED JENKINS-6446] Modified the scoring mechanism as follows to avo…
…id the inconsistency in granting marks.

    Passing test
        added: +1
        removed: -1
    Failing test
        added: -1
        removed: +1
    Skipped test (no marks given or reduced)
        added: 0
        removed: 0

Following is the details of how all scenarios are handled.

    Passing Tests
        Passing test added = +1
            [Increases passing count = +1]
        Passing test removed = -1
            [Decreases passing count = -1]
        Passing an already failing test = +2
            [Decreases failing count = +1]
            [Increases passing count = +1]
        Passing an already skipped test = +1
            [Decreases skipped count = 0]
            [Increases passing count = +1]

    Failing tests
        Failing test added = -1
            [Increases failing count = -1]
        Failing test removed = +1
            [Decreases failing count = +1]
        Failing an already passing test = -2
            [Decreases passing count = -1]
            [Increases failing count = -1]
        Failing an already skipped test = -1
            [Decreases skipped count = 0]
            [Increases failing count = -1]

    Skipped tests
        Skipped test added = 0
            [Increases skipped count = 0]
        Skipped test removed = 0
            [Decreases skipped count = 0]
        Skipped an already passing test = -1
            [Decreases passing count = -1]
            [Increases skipped count = 0]
        Skipped an already failing test = +1
            [Decreases failing count = +1]
            [Increases skipped count = 0]
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Oct 20, 2013

plugins » ci-game-plugin #6 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Oct 20, 2013

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@lkamal

This comment has been minimized.

Copy link
Contributor Author

commented Oct 20, 2013

Hi Jenkinsadmin,

Yes, and thanks for the link.

[FIXED JENKINS-6446] Added global configurations for all the six type…
…s of unittest changes (increase or descrease of passed, failed and skipped tests). The configuration is available under 'Continuous integration game - Unit Tests' section in advanced mode. Default values are set to 1 for increasing passing tests, -1 for increasing failed tests and 0 for all other 4 scenarios
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Oct 24, 2013

plugins » ci-game-plugin #7 SUCCESS
This pull request looks good

@lkamal

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2013

Hi all,

I have added global configurations for all the six types of unittest changes (increase or descrease of passed, failed and skipped tests).

Given default values are:
Passing test
added: +1
removed: 0
Failing test
added: -1
removed: 0
Skipped test (no marks given or reduced)
added: 0
removed: 0

The configuration is available under 'Continuous integration game - Unit Tests' section in advanced mode.

If you could review this and see whether this can be incorporated or provide more input; it will be helpful.

Thanks.

@simschla

This comment has been minimized.

Copy link
Member

commented Oct 27, 2013

I'm looking into it. First impressions:

  1. I like the idea of symmetric awards.
  2. I like that the admin is able to configure the scoring mechanism.

-> Input for the configuration page: I'd very much prefer if you modify the new section "Continuous integration game - Unit Tests" to be a sub-title of the existing "Continuous integration game". It makes no sense to have both at top-level configuration.

@lkamal

This comment has been minimized.

Copy link
Contributor Author

commented Oct 28, 2013

Hi Simon,

Thanks for the update.

I also wanted to have a subsection, but it seems most of the configs are having only one section (no sub section); so could not yet find the way to achieve this.

One option I found was to change the text of the "advanced" button to show "Unit Tests", so that when clicked the properties list is shown.

Could you please provide me with some info so that I can find a mechanism to create a sub-section under CI-Game section? If there is no such way, should I simply have the properties listed just below the "namesAreCase..." property under advanced mode?

@simschla

This comment has been minimized.

Copy link
Member

commented Oct 29, 2013

The "closest" thing to sub-sections I could think of is

  • Listing of JDK Installations/Locations (Core)
  • Listing of Git Installations (Git Plugin)
  • Meme Plugin (see screenshot)
    kind-of-subsection
@lkamal

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2013

Sure, I will look into that and update that section.

Thanks.

[FIXED JENKINS-6446] Modified the global config view of unit tests so…
… that it will be displayed in a separate table rather than using a top level title
@lkamal

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2013

Based on the meme plugin implementation, I updated the config page and updated the pull request.
(screeshots attached)

Hidden:
unittests-hidden

Visible (on click):
unittests-visible

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Oct 29, 2013

plugins » ci-game-plugin #8 SUCCESS
This pull request looks good

@simschla

This comment has been minimized.

Copy link
Member

commented Oct 30, 2013

That looks really nice. I'll go ahead and test it a little bit and if no one objects, I'll merge it this weekend. :)

@lkamal

This comment has been minimized.

Copy link
Contributor Author

commented Oct 30, 2013

Oki sure...

@simschla

This comment has been minimized.

Copy link
Member

commented Nov 3, 2013

I looked into it and it is a very good pull request in my opinion. Since no one else objected, I'll go ahead and merge it!

simschla added a commit that referenced this pull request Nov 3, 2013
Merge pull request #11 from lkamal/master
[FIXED JENKINS-6446] added global configurations for all the six types of unittest changes (increase or descrease of passed, failed and skipped tests)

@simschla simschla merged commit c662016 into jenkinsci:master Nov 3, 2013

@simschla

This comment has been minimized.

Copy link
Member

commented Jul 19, 2014

Just released a new version of the plugin.
@lkamal could you please update the Plugin-Description-Page in order to reflect the new default scoring mechanism and what is configurable? That would be very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.