Skip to content
Permalink
Branch: master
Commits on Apr 5, 2019
  1. [maven-release-plugin] prepare for next development iteration

    stephenc committed Apr 5, 2019
  2. [maven-release-plugin] prepare release cloudbees-folder-6.8

    stephenc committed Apr 5, 2019
Commits on Nov 16, 2018
  1. [maven-release-plugin] prepare for next development iteration

    stephenc committed Nov 16, 2018
  2. [maven-release-plugin] prepare release cloudbees-folder-6.7

    stephenc committed Nov 16, 2018
  3. Merge pull request #119 from stephenc/periodic-fixes

    stephenc committed Nov 16, 2018
    Some tweaks on how periodic if not otherwise ran works
Commits on Mar 7, 2018
  1. Some tweaks on how periodic if not otherwise ran works

    stephenc committed Mar 7, 2018
    - Should fix the "run every 1 minute" bug
Commits on Oct 16, 2017
  1. [JENKINS-47438] Add test and ensure the limit is strictly held

    stephenc committed Oct 16, 2017
    (tests found that limit+1 were being scheduled before this commit)
Commits on Oct 15, 2017
  1. [JENKINS-47438] Don't re-add if already in the list

    stephenc committed Oct 15, 2017
  2. [FIXED JENKINS-47438] Keep track of recent approvals to prevent race …

    stephenc committed Oct 15, 2017
    …conditions
Commits on Aug 4, 2017
  1. [maven-release-plugin] prepare for next development iteration

    stephenc committed Aug 4, 2017
  2. Merge pull request #106 from stephenc/jenkins-45984

    stephenc committed Aug 4, 2017
    [FIXED JENKINS-45984] Fix the crazy logic where 0 was semantically equivalent to 'empty' but actually wasn't
  3. [FIXED JENKINS-45984] Fix the crazy logic where 0 was semantically eq…

    stephenc committed Aug 4, 2017
    …uivalent to 'empty' but actually wasn't
    
    - All this crazy just to match the way LogRotator in core behaves
Commits on Aug 3, 2017
  1. [maven-release-plugin] prepare for next development iteration

    stephenc committed Aug 3, 2017
  2. Merge pull request #105 from stephenc/jenkins-43518

    stephenc committed Aug 3, 2017
    [FIXED JENKINS-43518] Missing doStop method preventing abort from console log
  3. [JENKINS-43518] Remove dead code

    stephenc committed Aug 3, 2017
  4. Merge pull request #104 from stephenc/jenkins-45823

    stephenc committed Aug 3, 2017
    [FIXED JENKINS-45823] Fix the defaulting of jelly form values
Commits on Jul 27, 2017
  1. [FIXED JENKINS-43518] Missing doStop method preventing abort from con…

    stephenc committed Jul 27, 2017
    …sole log
  2. [FIXED JENKINS-45823] Fix the defaulting of jelly form values

    stephenc committed Jul 27, 2017
Commits on Jul 17, 2017
  1. [maven-release-plugin] prepare for next development iteration

    stephenc committed Jul 17, 2017
Commits on Jul 14, 2017
  1. Merge pull request #101 from stephenc/jenkins-45322

    stephenc committed Jul 14, 2017
    [FIXED JENKINS-45322] Computed folder should disable orphaned items
  2. Merge pull request #100 from raul-arabaolaza/JENKINS-45501

    stephenc committed Jul 14, 2017
    [JENKINS-45501] cloudbees-folder is failing in the PCT against cores 2.32, 2.42 and 2.60
  3. [JENKINS-45322] Update test assumptions to reflect disabled folders n…

    stephenc committed Jul 14, 2017
    …ot building
  4. [JENKINS-45322] Computed folders should support being disabled (as th…

    stephenc committed Jul 13, 2017
    …ey have the concept of "building")
  5. [JENKINS-45322] The orphaned item strategy should be aware of last co…

    stephenc committed Jul 13, 2017
    …mputation times and prefer retention of recently disabled items over previously disabled items
  6. Fix the tests on windows (#103)

    stephenc committed Jul 14, 2017
    So, here's the analysis as to what was going on here:
    
    1. We have http://bugs.java.com/bugdatabase/view_bug.do?bug_id=4244499 as the bug that keeps on giving.
    2. FilePath.unzip uses ant's ZipFile (which has an encoding support constructor) but doesn't specify the encoding so the platform encoding is used
    3. The test data set is extracted from a ZIP file that has NFD names in UTF-8. Windows filesystem does not do unicode normalization and JenkinsRule unzips the names using platform encoding, so the names get converted through the equivalent of `new String(orig.getBytes("UTF-8"), "Windows-1252")`
    
    I have managed to fix up all the expected data on the basis that windows is using `Windows-1252`, I suspect a different default code-page would require additional changes to the test data (a future exercise to the foolish would be to actually generate the expected test data from the platform encoding, but then you need to determine whether the underlying filesystem does normalization or leaves it as is)
    
    To summarize:
    
    * OS-X normalizes to NFD and will handle names as `UTF-8`
    * Linux normalizes to NFC and will handle names as `UTF-8` (at least on all the systems I have tried so far, I suspect a different default locale could change that)
    * Windows does normalize and will handle names as `Windows-1252` (at least on our CI server)
Commits on Jul 13, 2017
  1. Merge pull request #102 from stephenc/jdk-8170447-workaround

    stephenc committed Jul 13, 2017
    [JDK-8170447] This is the only {@link} to an annotation I could find
  2. Update parent while we are at it

    stephenc committed Jul 13, 2017
  3. [JDK-8170447] Found it through a painful process of elimination

    stephenc committed Jul 13, 2017
Older
You can’t perform that action at this time.