Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-37369] Expose the last computation for computed folders #87

Merged
merged 3 commits into from Mar 16, 2017

Conversation

Projects
None yet
3 participants
@stephenc
Copy link
Member

commented Feb 27, 2017

See JENKINS-37369

@reviewbybees

Exposes the last computation information (so will only ever be either success or failure until we add computation history support)

screen shot 2017-02-27 at 13 18 07

@reviewbybees

This comment has been minimized.

Copy link

commented Feb 27, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick
Copy link
Member

left a comment

Have you had a glance at this from a UX person? From looking at the screenshot it is not at all obvious that the “last success” refers to an organization reindexing. I would have assumed that this referred to the most recent branch project build somewhere inside.

}

public HttpResponse doIndex(StaplerRequest request) {
return HttpResponses.redirectTo(Jenkins.getActiveInstance().getRootUrlFromRequest() + computation.getUrl() );

This comment has been minimized.

Copy link
@jglick

jglick Feb 27, 2017

Member

Just use

return HttpResponses.redirectViaContextPath(computation.getUrl());
@stephenc

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2017

Given that the build now button is (as of Jenkins 2.50) saying "Schedule a Scan ..." I would expect that the Last XXX columns refer to that scan:

screen shot 2017-03-10 at 11 01 44

@stephenc stephenc merged commit 4dda5fc into jenkinsci:master Mar 16, 2017

1 check passed

Jenkins This pull request looks good
Details

@stephenc stephenc deleted the stephenc:jenkins-37369 branch Mar 16, 2017

@stephenc

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2017

Merged resulting from Patrick's comments on the JIRA ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.