Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-20706] Support matrix builds #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@msabramo
Copy link
Contributor

@msabramo msabramo commented Jan 21, 2014

by copying and parsing coverage.xml files from each MatrixRun.

This is my second attempt at addressing
https://issues.jenkins-ci.org/browse/JENKINS-20706

This works by creating a MatrixAggregator that on endRun, copies the coverage.xml from each MatrixRun into the root build's directory. Then in endBuild, those files are parsed and aggregated.

The advantage of this approach is that it seems to aggregate the coverage in a nice way -- i.e.: if my MatrixBuild does a MatrixRun for Python versions 2.6, 2.7, and 3.3 and each of those has lines that are not covered but all of the lines are covered by at least one MatrixRun, then the coverage for the overall build will be reported as 100%.

Refs:

Cc: @ssogabe, @kinow, @emanuelez, @kohsuke

test

msabramo added a commit to msabramo/cobertura-plugin that referenced this issue Jan 21, 2014
by copying and parsing coverage.xml files from each MatrixRun.

This is my second attempt at addressing
https://issues.jenkins-ci.org/browse/JENKINS-20706

This works by creating a MatrixAggregator that on endRun, copies the
coverage.xml from each MatrixRun into the root build's directory. Then
in endBuild, those files are parsed and aggregated.

Refs:
* https://issues.jenkins-ci.org/browse/JENKINS-20706
* jenkinsci#26 (this PR)
* jenkinsci#22 (older PR)
@cloudbees-pull-request-builder

plugins » cobertura-plugin #47 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

plugins » cobertura-plugin #48 SUCCESS
This pull request looks good

msabramo added a commit to msabramo/cobertura-plugin that referenced this issue Jan 21, 2014
by copying and parsing coverage.xml files from each MatrixRun.

This is my second attempt at addressing
https://issues.jenkins-ci.org/browse/JENKINS-20706

This works by creating a MatrixAggregator that on endRun, copies the
coverage.xml from each MatrixRun into the root build's directory. Then
in endBuild, those files are parsed and aggregated.

Refs:
* https://issues.jenkins-ci.org/browse/JENKINS-20706
* jenkinsci#26 (this PR)
* jenkinsci#22 (older PR)
@cloudbees-pull-request-builder

plugins » cobertura-plugin #49 SUCCESS
This pull request looks good

msabramo added a commit to msabramo/cobertura-plugin that referenced this issue Jan 21, 2014
by copying and parsing coverage.xml files from each MatrixRun.

This is my second attempt at addressing
https://issues.jenkins-ci.org/browse/JENKINS-20706

This works by creating a MatrixAggregator that on endRun, copies the
coverage.xml from each MatrixRun into the root build's directory. Then
in endBuild, those files are parsed and aggregated.

Refs:
* https://issues.jenkins-ci.org/browse/JENKINS-20706
* jenkinsci#26 (this PR)
* jenkinsci#22 (older PR)
@cloudbees-pull-request-builder

plugins » cobertura-plugin #50 SUCCESS
This pull request looks good

@jenkinsadmin
Copy link
Member

@jenkinsadmin jenkinsadmin commented Jan 21, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

msabramo added a commit to msabramo/cobertura-plugin that referenced this issue Jan 22, 2014
by copying and parsing coverage.xml files from each MatrixRun.

This is my second attempt at addressing
https://issues.jenkins-ci.org/browse/JENKINS-20706

This works by creating a MatrixAggregator that on endRun, copies the
coverage.xml from each MatrixRun into the root build's directory. Then
in endBuild, those files are parsed and aggregated.

Refs:
* https://issues.jenkins-ci.org/browse/JENKINS-20706
* jenkinsci#26 (this PR)
* jenkinsci#22 (older PR)
@cloudbees-pull-request-builder

plugins » cobertura-plugin #51 SUCCESS
This pull request looks good

@msabramo msabramo closed this Jan 22, 2014
@msabramo msabramo deleted the support_matrix_projects_2 branch Jan 22, 2014
@msabramo msabramo restored the support_matrix_projects_2 branch Jan 22, 2014
@msabramo msabramo deleted the support_matrix_projects_2 branch Jan 22, 2014
by copying and parsing coverage.xml files from each MatrixRun.

This is my second attempt at addressing
https://issues.jenkins-ci.org/browse/JENKINS-20706

This works by creating a MatrixAggregator that on endRun, copies the
coverage.xml from each MatrixRun into the root build's directory. Then
in endBuild, those files are parsed and aggregated.

Refs:
* https://issues.jenkins-ci.org/browse/JENKINS-20706
* jenkinsci#26 (this PR)
* jenkinsci#22 (older PR)
msabramo added a commit to msabramo/cobertura-plugin that referenced this issue Jan 22, 2014
by copying and parsing coverage.xml files from each MatrixRun.

This is my second attempt at addressing
https://issues.jenkins-ci.org/browse/JENKINS-20706

This works by creating a MatrixAggregator that on endRun, copies the
coverage.xml from each MatrixRun into the root build's directory. Then
in endBuild, those files are parsed and aggregated.

Refs:
* https://issues.jenkins-ci.org/browse/JENKINS-20706
* jenkinsci#26 (this PR)
* jenkinsci#22 (older PR)
@msabramo msabramo reopened this Jan 22, 2014
@cloudbees-pull-request-builder

plugins » cobertura-plugin #52 SUCCESS
This pull request looks good

@msabramo
Copy link
Contributor Author

@msabramo msabramo commented Jul 3, 2014

Ping

@ulope
Copy link

@ulope ulope commented Aug 18, 2014

I would really like to use this feature. @msabramo seems to have done all the heavy lifting already. Can anyone from jenkins comment what remains to be done to get it merged?

@msabramo
Copy link
Contributor Author

@msabramo msabramo commented Oct 5, 2014

I would love for someone more steeped in Java and Jenkins plug-ins to take this over and take it across the finish line...

@msabramo
Copy link
Contributor Author

@msabramo msabramo commented Dec 18, 2014

I would really like to use this feature. @msabramo seems to have done all the heavy lifting already.
Can anyone from jenkins comment what remains to be done to get it merged?

@msabramo
Copy link
Contributor Author

@msabramo msabramo commented Dec 18, 2014

Posted a message on the jenkinsci-dev mailing list -- I hope that gets some attention and that someone can continue to work on this and complete it.

https://groups.google.com/forum/#!topic/jenkinsci-dev/Bo_m4KMyccI

@kyluca
Copy link

@kyluca kyluca commented Jul 27, 2016

I would really really love this functionality. Hope a Jenkins dev sees this soon...

@Itja
Copy link

@Itja Itja commented Mar 1, 2019

🎉 Belated happy fifth birthday to this PR! 🎂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants