Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-6684] Cobertura plugin should autoconfigure for Maven projects #35

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@dennisl
Copy link

dennisl commented Sep 8, 2014

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Sep 8, 2014

plugins » cobertura-plugin #66 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Sep 8, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@KostyaSha

This comment has been minimized.

Copy link
Member

KostyaSha commented Mar 4, 2015

This doesn't look like autoconfigure of maven job, for maven-plugin integration you need define special publisher AFAIR, then it will have no UI options and will use hardcoded values. junit-plugin can be as example.

@dennisl

This comment has been minimized.

Copy link
Author

dennisl commented Mar 4, 2015

It is not autoconfigure in the sense that it looks into the POM of the Maven project, to find the correct value.

What my pull request does, and what the original poster wants (see JIRA issue) is for the Jenkins plugin to supply a reasonable default value.

@KostyaSha

This comment has been minimized.

Copy link
Member

KostyaSha commented Mar 4, 2015

Then name commit accordingly "Provide default value"

@dennisl

This comment has been minimized.

Copy link
Author

dennisl commented Mar 4, 2015

I'm accustomed to always use the title of the issue for the commit message. And since I was not the one who reported the issue I didn't want to change the title of the issue. Feel free to change the title to something more appropriate if you want to. I just want to get my pull request merged and a release made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.