Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generating coverage report on failed builds #46

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@arcivanov
Copy link
Contributor

arcivanov commented Aug 13, 2015

It is useful to be able to generate reports on failed builds if Coverage is generated but build failed due to build coverage failure
Also it is useful to keep sources for all the builds
Also upgraded to latest LTS

@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Aug 13, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@arcivanov

This comment has been minimized.

Copy link
Contributor Author

arcivanov commented Aug 13, 2015

retest this please

@@ -54,7 +54,9 @@

private final String coberturaReportFile;

private final boolean onlyStable;
private final boolean unstable;

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Oct 18, 2015

Member

There is no data migration code. You are going to break existing plugin installations

*
* @return the unstable
*/
public boolean getUnstable()

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Oct 18, 2015

Member

Better to use isUnstable()

* @param sourceEncoding
* @param maxNumberOfBuilds
*/
public CoberturaPublisher(String coberturaReportFile, boolean onlyStable, boolean failUnhealthy, boolean failUnstable,

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Oct 18, 2015

Member

It would be better to mark this constructor as deprecated. Such Javadoc without param descriptions makes no sense. It will also affect builds with JDK8, which run javadoc lint by default

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Oct 18, 2015

👎 This pull request changes data fields in the publisher and does not provide data migration. More info https://wiki.jenkins-ci.org/display/JENKINS/Hint+on+retaining+backward+compatibility

@arcivanov

This comment has been minimized.

Copy link
Contributor Author

arcivanov commented Oct 18, 2015

@oleg-nenashev Thanks for feedback, I will rework the PR to your satisfaction.

@arcivanov arcivanov force-pushed the arcivanov:unstable_failed_threshold branch 4 times, most recently from dfed083 to 6b72230 Oct 26, 2015

It is useful to be able to generate reports on failed builds if Cover…
…age is generated but build failed due to build coverage failure

Also it is useful to keep sources for all the builds
Also upgrade to latest LTS

@arcivanov arcivanov force-pushed the arcivanov:unstable_failed_threshold branch from 6b72230 to b6a71a8 Oct 27, 2015

@arcivanov

This comment has been minimized.

Copy link
Contributor Author

arcivanov commented Oct 27, 2015

@oleg-nenashev could you review please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.