Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing JENKINS-12640 #6

Merged
merged 1 commit into from May 5, 2012
Merged

Fixing JENKINS-12640 #6

merged 1 commit into from May 5, 2012

Conversation

@plaflamme
Copy link
Contributor

plaflamme commented Apr 19, 2012

Patch for fixing https://issues.jenkins-ci.org/browse/JENKINS-12640.

My first Jenkins code contribution, so there might be a better way to do this. I've tested this patch on my own multi-module build and it works.

@buildhive

This comment has been minimized.

Copy link

buildhive commented Apr 19, 2012

ssogabe added a commit that referenced this pull request May 5, 2012
@ssogabe ssogabe merged commit 85bcedd into jenkinsci:master May 5, 2012

private boolean didCoberturaRun(MavenBuild mavenBuild) {
for(ExecutedMojo mojo : mavenBuild.getExecutedMojos()) {
if(mojo.groupId.equals("org.codehaus.mojo") && mojo.artifactId.equals("cobertura-maven-plugin")) {

This comment has been minimized.

Copy link
@cecom

cecom Jul 6, 2012

Due to that change my builds results in "Skipping Cobertura coverage report as mojo did not run". I execute cobertura via ant and not via the cobertura-maven-plugin so i can get a complete report over all my submodules. Can you use another check, instead of asking the maven build? For example, check of existense of a file?

This comment has been minimized.

Copy link
@HenrikGammelgaard-zmags

HenrikGammelgaard-zmags Aug 20, 2012

I face a similar problem in that I generate a cobertura file via js-test-driver and as such do not run the maven plugin.

This comment has been minimized.

Copy link
@recampbell

recampbell Aug 27, 2012

Member

Yes, this seems to have broken non-M2 project types' usage of cobertura. See https://issues.jenkins-ci.org/browse/JENKINS-12640

This comment has been minimized.

Copy link
@egergo

egergo Oct 8, 2012

I really think that this check is a bad solution for JENKINS-12640. I use ant to generate the coverage report xml, so no cobertura mojo was run. Jenkins does not read this xml (although the xml is valid and the path is correct) since v1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.