New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConditionalBuilder now implements DependencyDeclarer #12

Merged
merged 3 commits into from Jan 12, 2017

Conversation

Projects
None yet
3 participants
@TWestling
Member

TWestling commented Oct 13, 2016

SingleConditionalBuilder already implements the correct
DependencyDeclarer. This change makes it so that
ConditionalBuilder does the same.

This is needed to get downstream functionality of e.g. the Junit plugin aggregation and downstream- buildview to work.

ConditionalBuilder now implements DependencyDeclarer
SingleConditionalBuilder already implements the correct
DependencyDeclarer. This change makes it so that
ConditionalBuilder does the same.
@TWestling

This comment has been minimized.

Show comment
Hide comment
@TWestling

TWestling Oct 19, 2016

Member

@imod Could you take a look at this? It is basically the same as #10 but for the multi step instead of single step.

Member

TWestling commented Oct 19, 2016

@imod Could you take a look at this? It is basically the same as #10 but for the multi step instead of single step.

@imod

This comment has been minimized.

Show comment
Hide comment
@imod

imod Oct 24, 2016

Member

@TWestling looks good to me - I'll merge is in the next couple of days

Member

imod commented Oct 24, 2016

@TWestling looks good to me - I'll merge is in the next couple of days

Fix for broken dependency graph creation
All build steps get added to the dependency graph,
no matter what the conditions are. This change remedies this
by using the ConditionalDependencyGraphWrapper from the
flexible-publish plugin.
@TWestling

This comment has been minimized.

Show comment
Hide comment
@TWestling

TWestling Oct 26, 2016

Member

@imod I noticed that this doesn't work as is for e.g. the parameterized trigger, nor does it work for pull #10 Since we add every builder to the dependencygraph, even if the condition returns false, the graph will make sure that it runs anyway. This is solved in the flexible-publish plugin so the simplest solution is to add a dependency to flexible-publish. I'll add that change to this pull request, please have a look.

Member

TWestling commented Oct 26, 2016

@imod I noticed that this doesn't work as is for e.g. the parameterized trigger, nor does it work for pull #10 Since we add every builder to the dependencygraph, even if the condition returns false, the graph will make sure that it runs anyway. This is solved in the flexible-publish plugin so the simplest solution is to add a dependency to flexible-publish. I'll add that change to this pull request, please have a look.

@imod

This comment has been minimized.

Show comment
Hide comment
@imod

imod Oct 27, 2016

Member

@TWestling sorry, I don't like the dependency to the flexible-publish - can't we just do it the same way as it is done there?

Member

imod commented Oct 27, 2016

@TWestling sorry, I don't like the dependency to the flexible-publish - can't we just do it the same way as it is done there?

@TWestling

This comment has been minimized.

Show comment
Hide comment
@TWestling

TWestling Oct 28, 2016

Member

@imod I was thinking you would say that :)
It looks like the support is mostly done by 2 classes so sure, I can copy those over here. I will update this PR with the changes, probably next week.

Member

TWestling commented Oct 28, 2016

@imod I was thinking you would say that :)
It looks like the support is mostly done by 2 classes so sure, I can copy those over here. I will update this PR with the changes, probably next week.

@imod

This comment has been minimized.

Show comment
Hide comment
@imod

imod Nov 17, 2016

Member

@TWestling any plans to finish this?

Member

imod commented Nov 17, 2016

@TWestling any plans to finish this?

@TWestling

This comment has been minimized.

Show comment
Hide comment
@TWestling

TWestling Jan 10, 2017

Member

@imod Yes, this slipped my mind as we started using my version of the plugin and then I forgot about it. I'll reopen it now.

Member

TWestling commented Jan 10, 2017

@imod Yes, this slipped my mind as we started using my version of the plugin and then I forgot about it. I'll reopen it now.

Removed dependency to flexible publish plugin
Copied the needed classes from the flexible publish plugin
and removed the dependency from this plugin.
@TWestling

This comment has been minimized.

Show comment
Hide comment
@TWestling

TWestling Jan 10, 2017

Member

@ikedam I've copied two of your classes from the flexible-publish-plugin in order to get the dependency graph to work as it should. I copied them in as they were and just added a note regarding where they came from, I hope this is ok.

Member

TWestling commented Jan 10, 2017

@ikedam I've copied two of your classes from the flexible-publish-plugin in order to get the dependency graph to work as it should. I copied them in as they were and just added a note regarding where they came from, I hope this is ok.

@ikedam

This comment has been minimized.

Show comment
Hide comment
@ikedam

ikedam Jan 10, 2017

Member

@TWestling Looks good to me.

Member

ikedam commented Jan 10, 2017

@TWestling Looks good to me.

@TWestling

This comment has been minimized.

Show comment
Hide comment
@TWestling

TWestling Jan 12, 2017

Member

@imod I removed the dependency to the flexible-publisher plugin, could you have a look?

Member

TWestling commented Jan 12, 2017

@imod I removed the dependency to the flexible-publisher plugin, could you have a look?

@imod

This comment has been minimized.

Show comment
Hide comment
@imod

imod Jan 12, 2017

Member

👍

Member

imod commented Jan 12, 2017

👍

@imod imod merged commit 354bcce into jenkinsci:master Jan 12, 2017

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment