New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-43887] Update parent POM to 2.X. #14

Merged
merged 2 commits into from May 8, 2017

Conversation

Projects
None yet
6 participants
@varyvol

varyvol commented Apr 27, 2017

JENKINS-43887

  • Uses 2.26 parent POM.
  • Bump some dependencies.
  • Fix tests.
  • Fix Findbugs errors.

@reviewbybees @jglick @kwhetstone @andresrc @imod @bap2000

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Apr 27, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

reviewbybees commented Apr 27, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@kwhetstone

This comment has been minimized.

Show comment
Hide comment
@kwhetstone

kwhetstone commented Apr 27, 2017

🐝

@jglick

jglick approved these changes Apr 27, 2017

@@ -111,7 +111,12 @@ private ConditionalBuildStepHelper() {
* @return
*/
public static boolean isMavenPluginInstalled() {
final hudson.Plugin plugin = Jenkins.getInstance().getPlugin("maven-plugin");
return plugin != null ? plugin.getWrapper().isActive() : false;
Jenkins j = Jenkins.getInstance();

This comment has been minimized.

@jglick

jglick Apr 27, 2017

Member

Can just use getActiveInstance.

@jglick

jglick Apr 27, 2017

Member

Can just use getActiveInstance.

This comment has been minimized.

@varyvol

varyvol Apr 28, 2017

It's not available, maybe it was introduced after 1.580.1?

@varyvol

varyvol Apr 28, 2017

It's not available, maybe it was introduced after 1.580.1?

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Apr 28, 2017

Member

IIRC the first release with this method is 1.596.

@oleg-nenashev

oleg-nenashev Apr 28, 2017

Member

IIRC the first release with this method is 1.596.

@oleg-nenashev

🐝

@varyvol

This comment has been minimized.

Show comment
Hide comment
@varyvol

varyvol May 8, 2017

@imod could you review and merge this if appropriate?

varyvol commented May 8, 2017

@imod could you review and merge this if appropriate?

@imod

This comment has been minimized.

Show comment
Hide comment
@imod

imod May 8, 2017

Member

@varyvol thanks!

Member

imod commented May 8, 2017

@varyvol thanks!

@imod imod merged commit 3a5abfc into jenkinsci:master May 8, 2017

1 check passed

Jenkins This pull request looks good
Details
@varyvol

This comment has been minimized.

Show comment
Hide comment
@varyvol

varyvol Jun 7, 2017

@imod would it be possible to release a new version including these changes?

varyvol commented Jun 7, 2017

@imod would it be possible to release a new version including these changes?

@imod

This comment has been minimized.

Show comment
Hide comment
@imod

imod Jun 9, 2017

Member

@varyvol done...

Member

imod commented Jun 9, 2017

@varyvol done...

@varyvol

This comment has been minimized.

Show comment
Hide comment
@varyvol

varyvol Jun 9, 2017

@imod thank you very much!

varyvol commented Jun 9, 2017

@imod thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment