New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the JSON Schema Documentation page #1030
Conversation
@oleg-nenashev @Casz This should do it right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR checklist is not really followed, not a consumable chamgelog entry I would also suggest to start creating a new documentation page for schema instead of keeping it on landing. Will help with future changes
https://github.com/jenkins-infra/jenkins.io/tree/master/content/projects/jcasc |
New page under https://github.com/jenkinsci/configuration-as-code-plugin/tree/master/docs/features would be my recommendation |
@oleg-nenashev @Casz This looks fine ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add title to the page and coordinate the merge with the feature release.
Also, my comment about the pull request title has not been addressed yet
84c9e45
to
5bae285
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Link from the root pages is missing
- There is no reference to the old JSON generation and the differences. IMHO it should be documented somehow with proper disclaimers
6b20149
to
1eaad57
Compare
Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready to go once the feature is integrated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates are needed after recent changes in #980
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page still need to be referenced from README. The rest looks good to me
@oleg-nenashev Yeah added it :) |
Changing the doc to include the Beta Release of JSON Schema
Your checklist for this pull request
馃毃 Please review the guidelines for contributing to this repository.