Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another method for configuration reload #1068

Merged
merged 2 commits into from Oct 3, 2019

Conversation

@szandala
Copy link
Contributor

commented Sep 17, 2019

I've added missing method for configuration reload

Your checklist for this pull request

馃毃 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.
README.md Outdated
@@ -338,10 +338,10 @@ secrets:

We don't support installing plugins with JCasC you need to use something else for this,

Dockers users can use:
Dockers users can use:

This comment has been minimized.

Copy link
@casz

casz Sep 17, 2019

Member

On markdown please do no trim double white spaces. Double white spaces and newline creates a line break
https://gist.github.com/shaunlebron/746476e6e7a4d698b373

Suggested change
Dockers users can use:
Dockers users can use:
README.md Outdated
[https://github.com/jenkinsci/docker/#preinstalling-plugins](https://github.com/jenkinsci/docker/#preinstalling-plugins)

Kubernetes users:
Kubernetes users:

This comment has been minimized.

Copy link
@casz

casz Sep 17, 2019

Member

Ditto

Suggested change
Kubernetes users:
Kubernetes users:
@@ -372,7 +378,7 @@ You have the following option to trigger a configuration reload:
Allows to resolve secrets from AWS' SSM secrets
- [hashicorp-vault-plugin](https://github.com/jenkinsci/hashicorp-vault-plugin)
Allows to resolve secrets from Hashicorp vault

This comment has been minimized.

Copy link
@casz

casz Sep 17, 2019

Member

Double empty line please remove one

Suggested change
@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

@szandala hi, are you still interested?

@szandala

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Overall, yes I am.
I had a flu for almost a week and I have limited my duties :p
I will check the complains

@szandala szandala force-pushed the szandala:new_method branch from be90dc8 to 68cc4f6 Oct 2, 2019
@szandala szandala force-pushed the szandala:new_method branch from 68cc4f6 to 092070c Oct 2, 2019
@szandala

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

@casz for adding newline cannot we use slash?

@casz

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

I was not aware of \ for newlines 馃槺 What MAGIC

@szandala

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Now what then?

@szandala

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Btw. can I add label:
Hacktoberfest ?
It was no planned, but since I can get a T-shirt :p

@timja timja added the hacktoberfest label Oct 2, 2019
@timja

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Btw. can I add label:
Hacktoberfest ?
It was no planned, but since I can get a T-shirt :p

I don't think you need the label? but have added anyway

@casz
casz approved these changes Oct 2, 2019
@timja
timja approved these changes Oct 2, 2019
@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

@szandala Hacktoberfest won't work retrospectively for old PRs IIRC, but let's see

@szandala

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

@szandala Hacktoberfest won't work retrospectively for old PRs IIRC, but let's see

yeah, they told me that now...

Who can merge the PR anyway?

@timja timja added the documentation label Oct 3, 2019
@timja timja merged commit 19b4590 into jenkinsci:master Oct 3, 2019
9 of 10 checks passed
9 of 10 checks passed
Build on Jenkins 2.60.3, JDK 1.8 and ubuntu-latest
Details
Build on Jenkins 2.60.3, JDK 1.8 and windows-latest
Details
Build on Jenkins 2.176.3, JDK 1.8 and ubuntu-latest
Details
Build on Jenkins 2.176.3, JDK 1.8 and windows-latest
Details
Build on Jenkins 2.176.3, JDK 11 and ubuntu-latest
Details
Build on Jenkins 2.176.3, JDK 11 and windows-latest
Details
LGTM analysis: Java No code changes detected
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@timja

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

@szandala Hacktoberfest won't work retrospectively for old PRs IIRC, but let's see

yeah, they told me that now...

Who can merge the PR anyway?

anyone who gives the green , was just giving time for others to review.

Copy link
Member

left a comment

Sorry, I was late. It is a nice enhancement indeed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.