New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate global libraries demo with the integrations framework #1221

Merged

timja merged 2 commits into jenkinsci:master from v1v:feature/demo-global-library

Dec 11, 2019

Member

v1v commented Dec 11, 2019

As a consequence of #1055 let's move each demos in independent PRs to track all the required dependencies.

integrations/src/test/resources/io/jenkins/plugins/casc/GlobalLibrariesTest.yml has been deleted since it's already tested with the demos.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or in Jenkins JIRA
Link to relevant pull requests, esp. upstream and downstream changes
Did you provide a test-case? That demonstrates feature works or fixes the issue.

v1v added 2 commits

December 10, 2019 23:23


          Demos: run integration tests for the global libraries example

fb6afd2


          split in two classes as the two Rules don't work quite well together

1f88d0d

timja approved these changes

View reviewed changes

timja added the test label

timja merged commit a9081fb into jenkinsci:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment