Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate top-level README with the integrations tests #1228 #1229

Merged
merged 1 commit into from Dec 24, 2019

Conversation

v1v
Copy link
Member

@v1v v1v commented Dec 15, 2019

As a consequence of #1055 let's move each demos in independent PRs to track all the required dependencies.

Tasks

  • Support top-level README.md to be validate with theConfiguredWithReadme annotation.
    • It required to transform demos/README.md to demos/README.adoc, to avoid a clash when solving the resources.
  • Change the credentials example since Remove credentials from support plugin聽#863 did remove it.

Your checklist for this pull request

馃毃 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@v1v v1v changed the title Validate top README with the Integrations tests Validate top-level README with the integrations tests #1228 Dec 15, 2019
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 馃槏

@oleg-nenashev
Copy link
Member

Thanks @v1v !

@oleg-nenashev oleg-nenashev merged commit b53eb77 into jenkinsci:master Dec 24, 2019
@oleg-nenashev oleg-nenashev added the chore a PR that adds to maintenance - used by Release Drafter label Dec 24, 2019
LinuxSuRen added a commit to alauda/configuration-as-code-plugin that referenced this pull request Feb 21, 2020
* Add support to backup and restore automatically

* Fix the potential output resource leak

* Add configs about deploy into alauda update-center

* Set alauda as the main branch

* Add sonarqube properties file

* Fix the potentital issues

* Add a merge strategy extension point for the YAML config (#1)

* Add YAML merge strategy

* Add a new merge strategy

* Remove override merge strategy

* Clean the unused code lines

* Clean the unused imports

* Add test cases for merge strategy

* Fix the wrong test cases

* Take merge strategy name everytime

* Give the default strategy a more readable name

* Validate top README with the Integrations tests (jenkinsci#1229)

* Fix the compilation error caused by merge strategy

* Fix issues which found by spotbugs

* Remove unused imports

* Move profiles from pom.xml into settings file

* Remove empty line

* rename the shared-library

* Schema Generation for nested yml configurations (jenkinsci#1027)

* Trying to diagnose some flaky tests (jenkinsci#1243)

* Update ci to include code coverage after jenkinsci#1215 (jenkinsci#1241)

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>

* Checkstyle ignore release.properties (jenkinsci#1245)

* [maven-release-plugin] prepare release configuration-as-code-1.35

* [maven-release-plugin] prepare for next development iteration

* Bump jackson.version from 2.10.1 to 2.10.2

Bumps `jackson.version` from 2.10.1 to 2.10.2.

Updates `jackson-databind` from 2.10.1 to 2.10.2
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `jackson-dataformat-yaml` from 2.10.1 to 2.10.2
- [Release notes](https://github.com/FasterXML/jackson-dataformats-text/releases)
- [Commits](FasterXML/jackson-dataformats-text@jackson-dataformats-text-2.10.1...jackson-dataformats-text-2.10.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Correct spelling of hpi.pluginChangelogUrl tag (jenkinsci#1248)

* Automatically request code reviews from all JCasC plugin developers (jenkinsci#1249)

* [Security] Bump checkstyle from 8.26 to 8.29

Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.26 to 8.29. **This update includes a security fix.**
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](checkstyle/checkstyle@checkstyle-8.26...checkstyle-8.29)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* It has been renamed to `master.componentName` (jenkinsci#1256)

Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>

* Fix the version specification for Jenkins 2.199 (jenkinsci#1268)

* Added example for credentials certificate (jenkinsci#1270)

* Use the latest shared-library branch

* Update test to match latest plugin version (jenkinsci#1273)

* Update the integration test for active-directory (jenkinsci#1274)

* Add integration test for pipeline-model-definition (jenkinsci#1276)

* Fix the error when no casc user dir (#5)

* Add missing of mode in the context

* Use the same version of jackson-core

* Use the same version of jackson-core

* Use 2.8 as the major version

* Fix the wrong parent id for the plugin releasing

* Move the user config into a backup dir

* Run build under java pod

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Co-authored-by: Sladyn <sladynnunes98@gmail.com>
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Co-authored-by: Joseph Petersen <josephp90@gmail.com>
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Jhon Mike <jhon.msdev@gmail.com>
Co-authored-by: Dawid Gos艂awski <50369002+dg-nvm@users.noreply.github.com>
Co-authored-by: choeffer <33625292+choeffer@users.noreply.github.com>
Co-authored-by: Francisco Fern谩ndez <31063239+fcojfernandez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a PR that adds to maintenance - used by Release Drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants