-
Notifications
You must be signed in to change notification settings - Fork 742
exclude hidden directories instead of Removes recursion subdirectories #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you please revert the formatting? makes the PR harder to review @readerx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM, perhaps someone with a k8s cluster can confirm it works as desired?
I have already confirmed it on the my k8s cluster. |
|
The question whether to include this or not was coined on office hours today. There seems to be use-cases for both of the behaviors so the idea coined there was using ant globs we use on so many places in Jenkins so customers have better control of what to include:
The downside I see is when this gets incorrectly quoted, the globs can be interpreted by shell before Jenkins is launched causing surprising results. |
This issue can be discussed separately |
|
Could you please review this PR? @ndeloof
If there are other good ways I can do it. |
|
I have modified the README.md. @ewelinawilkosz |
README.md
Outdated
| - A full path to a single file. For example, `/var/jenkins_home/casc_configs/jenkins.yaml`. | ||
| - A URL pointing to a file served on the web. For example, `https://acme.org/jenkins.yaml`. | ||
|
|
||
| If `CASC_JENKINS_CONFIG` point to a folder, the plugin will recursively traversing the folder to find file(suffix with .yml,.yaml,.YAML,.YML), but dosn't contain hidden files or hidden subdirectories. It dosn't follow symbolic links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of typos:
"points", "traverse", space between "file" and "(", and "doesn't" and we're good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you.
I have modified it according to your statement.
|
why revert this commit? it is a very useful feature |
|
the revert was clicked by mistake (I didn't even notice...), there is no plan to revert it |
|
I see, thanks |
The following scenarios are supported
There are a number of different types of configurations, like:
/var/jenkins_home/casc_configs/kubernetes-slave/<slave1.yamls、slave2.yaml .......>
/var/jenkins_home/casc_configs/credentials/<credentials1.yaml、credentials2.yaml.......>
/var/jenkins_home/casc_configs/default/<a.yaml、b.yaml........>
/var/jenkins_home/casc_configs/authorization-strategy/<auth1.yaml、auth2.yaml.......>
#629
#751