Skip to content
Permalink
Browse files

JENKINS-19858, JENKINS-14521, JENKINS-18794

  • Loading branch information...
jacobrobertson committed Oct 2, 2013
1 parent 52acc7d commit 06db2412c183d4fd39d763d048556a2a88572090
@@ -54,7 +54,7 @@ public String getUrl() {
} else {
List<String> ret = new ArrayList<String>();
List<Maven> builders = getBuilders(item);
if (builders.isEmpty()) {
if (builders == null || builders.isEmpty()) {
return ret;
}
String last = null;
@@ -75,6 +75,10 @@ public String getUrl() {
}
private List<Maven> getBuilders(AbstractProject item) {
DescribableList<Builder,Descriptor<Builder>> buildersList = AbstractBuildCommandSliceSpec.getBuildersList(item);
// JENKINS-18794 - couldn't reproduce, but this is the problematic line
if (buildersList == null) {
return null;
}
List<Maven> builders = buildersList.getAll(Maven.class);
return builders;
}
@@ -1,5 +1,5 @@
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt">
<l:layout title="${it.displayName}">
<l:layout title="${it.displayName}" norefresh="true">
<st:include page="sidepanel-executor.jelly" it="${it}"/>
<l:main-panel>
<f:form method="post" name="sliceconfig" action="sliceconfigSubmit">
@@ -4,11 +4,13 @@
<tr><th><b>
${it.spec.configuredValueDescription}
</b></th>
<th><st:nbsp /></th>
<th><b>Item Names</b></th></tr>
<j:forEach var="configuredValue" items="${it.configuredValues}">
<tr>
<td width="50%"><f:textarea name="configValue" value="${configuredValue}"/></td>
<td width="50%"><f:textarea name="itemNames" value="${it.getItemNamesString(configuredValue)}"/></td>
<td width="1%"><st:nbsp /></td>
<td width="49%"><f:textarea name="itemNames" value="${it.getItemNamesString(configuredValue)}"/></td>
</tr>
</j:forEach>
</table>

0 comments on commit 06db241

Please sign in to comment.
You can’t perform that action at this time.