Skip to content
Permalink
Browse files
[FIXED JENKINS-28011] Using the standard f:dropdownDescriptorSelector.
  • Loading branch information
jglick committed Apr 20, 2015
1 parent d574c00 commit e1a88091816e92243f9a4765679ba535588b7f74
@@ -26,7 +26,6 @@
import com.thoughtworks.xstream.converters.UnmarshallingContext;

import hudson.AbortException;
import hudson.DescriptorExtensionList;
import hudson.EnvVars;
import hudson.Extension;
import hudson.FilePath;
@@ -268,10 +267,15 @@ public String getParameters() {
return parameters;
}

@Deprecated
public BuildSelector getBuildSelector() {
return selector;
}

public BuildSelector getSelector() {
return selector;
}

public String getFilter() {
return filter;
}
@@ -523,9 +527,6 @@ public String getDisplayName() {
return Messages.CopyArtifact_DisplayName();
}

public DescriptorExtensionList<BuildSelector,Descriptor<BuildSelector>> getBuildSelectors() {
return Hudson.getInstance().<BuildSelector,Descriptor<BuildSelector>>getDescriptorList(BuildSelector.class);
}
}

// Listen for project renames and update property here if needed.
@@ -26,8 +26,7 @@ THE SOFTWARE.
<f:entry title="${%Project name}" field="projectName">
<f:editableComboBox items="${app.topLevelItemNames}" clazz="setting-input"/>
</f:entry>
<ca:selectorList currentSelector="${instance.buildSelector}"
name="selector" title="${%Which build}"/>
<f:dropdownDescriptorSelector field="selector" title="${%Which build}"/>
<f:entry title="${%Artifacts to copy}" field="filter">
<f:textbox/>
</f:entry>
@@ -1160,7 +1160,6 @@ public void testFieldValidation() throws Exception {
// Other descriptor methods
assertTrue(descriptor.isApplicable(null));
assertTrue(descriptor.getDisplayName().length() > 0);
assertTrue(descriptor.getBuildSelectors().size() > 0);
}

@LocalData

0 comments on commit e1a8809

Please sign in to comment.