Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-28011] Using the standard f:dropdownDescriptorSelector #62

Merged

Conversation

Projects
None yet
4 participants
@jglick
Copy link
Member

commented Apr 20, 2015

JENKINS-28011

Code simplification which offers an alternative fix to jenkinsci/jenkins#1663.

I did not delete selectorList.jelly since it is still being used by BuildSelectorParameter/config.jelly and index.jelly, though that could surely be made to use the standard control as well.

Makes CopyArtifactTest.testPermission pass against 1.610. There are various other test failures running against this baseline, which I did not try to evaluate.

@reviewbybees

@jglick jglick changed the title [JENKINS-28011] Using the standard f:dropdownDescriptorSelector [WiP] [JENKINS-28011] Using the standard f:dropdownDescriptorSelector Apr 20, 2015

@jglick

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2015

Test failures because of the use of the nonstandard selector rather than the standard instance and databinding. Really the databinding in this plugin is a mess.

@jglick jglick changed the title [WiP] [JENKINS-28011] Using the standard f:dropdownDescriptorSelector [JENKINS-28011] Using the standard f:dropdownDescriptorSelector Apr 20, 2015

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Apr 21, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@stephenc

This comment has been minimized.

Copy link
Member

commented Apr 21, 2015

👍

@ikedam

This comment has been minimized.

Copy link
Member

commented Apr 25, 2015

Looks good.
As long as I tested, JENKINS-28011 also happens with BuildSelectorParameter (assumed "various other test failures running against 1.610").
We should remove ca:selectorList completely (even though JENKINS-28011 will be fixed in Jenkins-1.611).
I work for that in JENKINS-28094.

ikedam added a commit that referenced this pull request Apr 25, 2015

Merge pull request #62 from jglick/dropdownDescriptorSelector-JENKINS…
…-28011

[JENKINS-28011] Using the standard f:dropdownDescriptorSelector

@ikedam ikedam merged commit ff6073c into jenkinsci:master Apr 25, 2015

1 check passed

Jenkins This pull request looks good
Details

@ikedam ikedam referenced this pull request Apr 25, 2015

Merged

Removed ca:selectorList #63

@jglick jglick deleted the jglick:dropdownDescriptorSelector-JENKINS-28011 branch Apr 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.