-
Notifications
You must be signed in to change notification settings - Fork 16
Build everything with docker-compose #104
Build everything with docker-compose #104
Conversation
When I checkout this PR, I get:
|
@martinda Yeah That is the error I am talking about in the description. It cannot find the file to copy even though it should be able to copy everything. One of the reasons is the dockerignore, it is not allowing anything to be copied |
Then the
|
What is the goal at the end of this PR? Is it to run just docker commands and no maven commands? |
@martinda Yes the goal is to be able to run without maven because every user might not have maven installed |
@martinda updated docker ignore |
This should include changes to the readme to run the commands as well. |
This works fine for me and the readme is perfect. No additional commands required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It work for me too. I think this is very good. No need to locally build, it builds itself in images.
I am not an expert in docker image and container management, maybe the infra team will have feedback on how to manage this in the future. For now I think we can accept this PR.
* Modified backend dockerfile * Update .dockerignore * Made dockerfile changes
* Modified backend dockerfile * Update .dockerignore * Made dockerfile changes
This PR deals with creating the backend without relying on local tools.This has some errors with docker compose which need to be fixed before merging