This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Add getPluginList Controller API #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sladyn98
commented
Jun 10, 2020
...n/java/com/org/jenkins/custom/jenkins/distribution/service/services/UpdateCenterService.java
Show resolved
Hide resolved
src/main/java/com/org/jenkins/custom/jenkins/distribution/service/util/Util.java
Outdated
Show resolved
Hide resolved
| public PluginController(UpdateCenterService updateCenterService) { | ||
| this.updateCenterService = updateCenterService; | ||
| } | ||
|
|
There was a problem hiding this comment.
Should I put its usage here ? like a sort of api docs
There was a problem hiding this comment.
Yes! Always include extra documentation, it's never bad to leave notes for people (and even yourself!) who will be looking at this later.
sladyn98
added
feature
kwhetstone
suggested changes
Jun 11, 2020
| public PluginController(UpdateCenterService updateCenterService) { | ||
| this.updateCenterService = updateCenterService; | ||
| } | ||
|
|
There was a problem hiding this comment.
Yes! Always include extra documentation, it's never bad to leave notes for people (and even yourself!) who will be looking at this later.
...n/java/com/org/jenkins/custom/jenkins/distribution/service/services/UpdateCenterService.java
Outdated
Show resolved
Hide resolved
kwhetstone
reviewed
Jun 15, 2020
| public ResponseEntity<?> getPlugins() { | ||
| LOGGER.info("Request Received"); | ||
| try { | ||
| return new ResponseEntity<>(updateCenterService.downloadUpdateCenterJSON().toMap(), HttpStatus.OK); |
There was a problem hiding this comment.
Does this generic have a type?
There was a problem hiding this comment.
It is returning a Hash map, but I read it is best practise to leave it generic, if you want I could change it :)
kwhetstone
approved these changes
Jun 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the controllers for pulling in the update center.json.