Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-14515] Incorrect path separator used on Win slave from Unix master #20

Merged
merged 1 commit into from Sep 19, 2014

Conversation

Projects
None yet
3 participants
@jglick
Copy link
Member

commented Sep 17, 2014

JENKINS-14515. Unfortunately I have no idea how to write an automated test for this, since the bug only occurs when the slave is a different platform from the master.

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Sep 18, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Sep 18, 2014

The fix seems to be valid.
BTW, I suppose the issue appeared due to the erroneous fix of (JENKINS-20560), see #21 . It's a well-known issue with EnvVars::override() call.

I suppose both PRs should be merged. I'll also create am artificial unit test to check the response with "other" platform

@jglick

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2014

I think "PATH+" syntax is legitimate. This PR only ensures that the EnvVars is constructed properly. I am not sure I understand what #21 is correcting, but so long as you are somehow checking that it works, great!

oleg-nenashev added a commit that referenced this pull request Sep 19, 2014

Merge pull request #20 from jglick/JENKINS-14515-pathsep
[FIXED JENKINS-14515] Incorrect path separator used on Win slave from Unix master

@oleg-nenashev oleg-nenashev merged commit 6f33735 into jenkinsci:master Sep 19, 2014

1 check passed

default This pull request looks good
Details

@jglick jglick deleted the jglick:JENKINS-14515-pathsep branch Sep 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.