Skip to content
Permalink
Browse files

[FIXED JENKINS-15565] Make root link relative to preserve protocol

  • Loading branch information
vjuranek committed Jan 29, 2013
1 parent 115e992 commit 5c0f68cc0f839918ca811bedaba37c4c031a0535
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/main/java/hudson/plugins/disk_usage/DiskUsagePlugin.java
@@ -44,7 +44,7 @@ public String getDisplayName() {
}

public String getUrlName() {
return Hudson.getInstance().getRootUrl() + "plugin/disk-usage/";
return "/plugin/disk-usage/";

This comment has been minimized.

Copy link
@kutzi

kutzi Jan 29, 2013

Member

As discussed in https://issues.jenkins-ci.org/browse/JENKINS-16368 this will be wrong, if Jenkins is behind a reverse-proxy which changes the root context

This comment has been minimized.

Copy link
@jglick

jglick Jan 29, 2013

Member

Probably both the former and new values are wrong, as ea5d29c corrects: getUrlName should be relative. For an Action, a path starting with / is treated as relative to the context path—this is not the raw value of an href in the output.

}

@Override public String getDescription() {

0 comments on commit 5c0f68c

Please sign in to comment.