Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting port bindings fails if EnvInvisibleAction does not contain Port bindings #11

Merged
merged 1 commit into from Aug 18, 2014

Conversation

Projects
None yet
4 participants
@albers
Copy link
Member

commented Aug 18, 2014

bd51023 broke variable resolution for DOCKER_CONTAINER_IDS:
Create a Job with steps

  • Create container
  • Start container using $DOCKER_CONTAINER_IDS
    The build will fail with

Failed to execute Docker command Start container(s): No such container $DOCKER_CONTAINER_IDS

Reason: The first step creates an action without port bindings. The second step then fails silently with an NPE when creating the port binding environment variables. The code to add DOCKER_CONTAINER_IDS is not executed.

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Aug 18, 2014

plugins » docker-build-step-plugin #45 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Aug 18, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@vjuranek vjuranek merged commit 39bd5e9 into jenkinsci:master Aug 18, 2014

@vjuranek

This comment has been minimized.

Copy link
Member

commented Aug 18, 2014

Merged, thanks!

@albers albers deleted the albers:port-bindings-in-env-fix branch Aug 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.