Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-24414] Upgrade to docker-java 0.10.0 #13

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
3 participants
@albers
Copy link
Member

commented Sep 14, 2014

JENKINS-24414
docker-java 0.10.0 is required to support exposing ports properly on Docker 1.2.

In docker-java 0.10.0, packages got separated into API, core and implementation.
In order to better support alternative implementations, some implementation specific details got removed, so we no longer can check HTTP status codes in CreateImageComand and PullImageCommand. The ping command lost its return value as well.

I posted this PR as a series of smaller steps in order to make it more easily reviewable.
If you prefer a flattened version for merging, please let me know.

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Sep 15, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@vjuranek

This comment has been minimized.

Copy link
Member

commented Sep 15, 2014

Merged. Great work, thanks a lot!

@vjuranek vjuranek closed this Sep 15, 2014

@albers albers deleted the albers:JENKINS-24414 branch Sep 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.