Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with docker-commons-plugin #32

Closed
wants to merge 8 commits into from

Conversation

@wzheng2310
Copy link
Contributor

wzheng2310 commented Jun 12, 2015

CloudBees now publishes their docker-commons-plugin. It has a DockerRegistryEndpoint class which implements basically the same thing as DockerCredConfig that was implemented in docker-build-step-plugin.

This pull request is to integrate with docker-commons-plugin and removes DockerCredConfig.

wzheng2310 added 8 commits Dec 10, 2014
1. Add authentication support using AuthConfig.
2. Add Push command
3. Fix how PullImageCommand check if the image has been pulled
4. Add console log to PullImageCommand to log the output generated by
   docker remote API
After upstream has merged Wei's pull request to support Docker Push
command
Fix failure with commands that requires auth which was caused by docker-java
client lib's change.
@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Jun 13, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@vjuranek

This comment has been minimized.

Copy link
Member

vjuranek commented Jun 26, 2015

Merged (with some backward compatibility changes), thanks! And sorry for the delay.

@vjuranek vjuranek closed this Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.