Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-38018] Use docker-login wherever possible for registry credentials #133

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
3 participants
@jglick
Copy link
Member

commented Jan 31, 2018

Downstream of jenkinsci/docker-commons-plugin#67.

  • manual test
  • update demo to work with newer versions of everything

@reviewbybees

@ndeloof

ndeloof approved these changes Feb 6, 2018

@jglick jglick requested a review from abayer Feb 8, 2018

@jglick

This comment has been minimized.

Copy link
Member Author

commented Feb 9, 2018

@abayer

abayer approved these changes Feb 15, 2018

@abayer abayer merged commit cf80d9e into jenkinsci:master Feb 15, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@jglick jglick deleted the jglick:login-JENKINS-38018 branch Feb 16, 2018

jglick added a commit to jglick/docker-workflow-plugin that referenced this pull request May 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.