Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-28612] force json date format #16

Merged
merged 1 commit into from Jul 15, 2015

Conversation

@ndeloof
Copy link
Member

commented Jul 12, 2015

docker inspect -f {{.Created}} relying on go text/template do dump dates using time.Time.String(), not using expected json ISO8601 format
json Template function allows to enforce expected format, just need to skip additional json quotes

see moby/moby#14164

@ndeloof

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2015

@reviewbybees

This comment has been minimized.

Copy link

commented Jul 12, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Jul 12, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Jul 13, 2015

This approach seems to be better than #15
Does it somehow impact Docker client requirements?

@ndeloof

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2015

"json" template method did exist in 0.10 (https://github.com/docker/docker/blob/v0.10.0/api/client/cli.go#L19) so is safe to be use

@tfennelly

This comment has been minimized.

Copy link
Member

commented Jul 13, 2015

I agree, this approach does seem more reliable than #15. I assume this feature has been there for a while (is backward compatible with older docker client versions)?

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Jul 15, 2015

🐝

ndeloof added a commit that referenced this pull request Jul 15, 2015

@ndeloof ndeloof merged commit 6593498 into jenkinsci:master Jul 15, 2015

1 check passed

Jenkins This pull request looks good
Details
@runcom

This comment has been minimized.

Copy link

commented Jul 27, 2015

@jglick

This comment has been minimized.

Copy link
Member

commented Aug 3, 2015

Should fix JENKINS-28612.

@jglick jglick changed the title force json date format [JENKINS-28612] force json date format Aug 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.