Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-38018] Call newly available API #72

Merged
merged 1 commit into from Oct 5, 2016

Conversation

Projects
None yet
4 participants
@jglick
Copy link
Member

commented Oct 3, 2016

Provides better diagnostics for JENKINS-38018.

Downstream of jenkinsci/docker-commons-plugin#55.

See also #71.

@reviewbybees

@jglick jglick closed this Oct 4, 2016

@jglick

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2016

Forgot to deploy the upstream.

@jglick jglick reopened this Oct 4, 2016

@reviewbybees

This comment has been minimized.

Copy link

commented Oct 4, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@@ -56,9 +58,11 @@ public DockerRegistryEndpoint getRegistry() {
@Inject(optional=true) private transient RegistryEndpointStep step;
@StepContextParameter private transient Job<?,?> job;
@StepContextParameter private transient FilePath workspace;
@StepContextParameter private transient Launcher launcher;

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Oct 5, 2016

Member

Are these fields guaranteed to be nonnull?

This comment has been minimized.

Copy link
@jglick

jglick Oct 5, 2016

Author Member

Yes.

@oleg-nenashev
Copy link
Member

left a comment

🐝 btw

@stephenc

This comment has been minimized.

Copy link
Member

commented Oct 5, 2016

🐝 AIUI

@jglick jglick merged commit 0d391ed into jenkinsci:master Oct 5, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:registry-diag-JENKINS-38018 branch Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.