Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-32701] Escape percentage signs in the jenkins-wrapper batch #16

Conversation

@arthurschreiber
Copy link
Contributor

commented Jan 21, 2016

When writing workspace paths into the jenkins-wrapper.bat batch
script, percentage signs need to be escaped correctly. Otherwise
the batch script execution will silently fail when the workspace
path contains a percentage sign. This was encountered in a multi branch
workflow project.

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Jan 21, 2016

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@arthurschreiber

This comment has been minimized.

Copy link
Contributor Author

commented Jan 28, 2016

Hey @jglick - is anything keeping this from being merged?

@jglick

This comment has been minimized.

Copy link
Member

commented Mar 4, 2016

A merge conflict with master, and also there is no test reproducing the problem and confirming the fix.

Escape percentage signs in the jenkins-wrapper batch script.
When writing workspace paths into the `jenkins-wrapper.bat` batch
script, percentage signs need to be escaped correctly. Otherwise
the batch script execution will silently fail when the workspace
path contains a percentage sign. This was encountered in a multi branch
workflow project.

@arthurschreiber arthurschreiber force-pushed the arthurschreiber:arthur/correctly-escape-percentage-sign branch from 9fbcb7f to c87a49b Mar 11, 2016

@arthurschreiber

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2016

Hey @jglick, I've rebased this against the latest master changes and added a test case that will hang forever without this fix in place. Could you please merge this and push out a release ASAP? ❤️

@arthurschreiber

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2016

@jglick Ping?

@jglick jglick changed the title Escape percentage signs in the jenkins-wrapper batch script. [FIXED JENKINS-32701] Escape percentage signs in the jenkins-wrapper batch script Mar 24, 2016

@jglick

This comment has been minimized.

Copy link
Member

commented Mar 24, 2016

Linking to existing issue JENKINS-32701.

@jglick jglick changed the title [FIXED JENKINS-32701] Escape percentage signs in the jenkins-wrapper batch script [JENKINS-32701] Escape percentage signs in the jenkins-wrapper batch Mar 24, 2016

@jglick

This comment has been minimized.

Copy link
Member

commented Mar 24, 2016

Seems to work on both XP and 2012.

@jglick jglick merged commit c87a49b into jenkinsci:master Mar 24, 2016

1 check passed

Jenkins This pull request looks good
Details
@jglick

This comment has been minimized.

Copy link
Member

commented Mar 25, 2016

Released as 1.9. Thanks, and sorry for the delay (I have quite a backlog).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.