Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-33945 allow node provisioning when matching node is offline #187

Merged
merged 1 commit into from Mar 31, 2016

Conversation

Projects
None yet
2 participants
@tjbaker
Copy link
Contributor

commented Mar 31, 2016

You can not provision a new node when an existing node from the template
is marked offline. This change consults isOffline() to allow new node
provisioning. Nodes can either be offline due to channel errors or user
interaction. Either way, don't block new nodes.

JENKINS-33945 allow node provisioning when existing matching node is …
…offline

You can not provision a new node when an existing node from the template
is marked offline.  This change consults isOffline() to allow new node
provisioning.  Nodes can either be offline due to channel errors or user
interaction.  Either way, don't block new nodes.

@francisu francisu merged commit 1227f79 into jenkinsci:master Mar 31, 2016

1 check was pending

Jenkins Jenkins is validating pull request ...
Details
@francisu

This comment has been minimized.

Copy link
Member

commented Mar 31, 2016

I'm going to back this one out for now. I want to solve the problem of https://issues.jenkins-ci.org/browse/JENKINS-32690 which I think will also solve this problem. I think putting your fix in will break the feature of using a stopped node that already exists which is also important. I will try to get to this in the next couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.