Provide backwards compatibility for EC2Slave name change. #37

Merged
merged 2 commits into from Mar 5, 2013

Conversation

Projects
None yet
3 participants
Contributor

kpfleming commented Mar 5, 2013

Commit 8822256 changed the way that
Node objects are constructed from EC2Slave objects, in order to make the
Node 'name' fields more useful. It also added a field called 'instanceId'
to EC2Slave, and stopped relying on Node.getNodeName() to recover that
information. In order to provide compatibility with configurations from
before this change was made, this patch notes whether instanceId is null,
and if it is, extracts the instance ID from the Node's name.

@kpfleming kpfleming Provide backwards compatibility for EC2Slave name change.
Commit 8822256 changed the way that
Node objects are constructed from EC2Slave objects, in order to make the
Node 'name' fields more useful. It also added a field called 'instanceId'
to EC2Slave, and stopped relying on Node.getNodeName() to recover that
information. In order to provide compatibility with configurations from
before this change was made, this patch notes whether instanceId is null,
and if it is, extracts the instance ID from the Node's name.
44a9f29

Jenkins » ec2-plugin #54 SUCCESS
This pull request looks good
(what's this?)

@kpfleming kpfleming Document versions involved in instanceId backward compatibility code.
Also, make instanceId private (since it can no longer be final), as allowing
it to be modified from outside of EC2Slave itself would cause serious problems.
fede71f

Jenkins » ec2-plugin #55 SUCCESS
This pull request looks good
(what's this?)

Member

francisu commented Mar 5, 2013

Thanks for your contribution.

francisu merged commit 64a311d into jenkinsci:master Mar 5, 2013

kpfleming deleted the kpfleming:ec2slave-support-old-data branch Mar 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment