Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate adding findsecbugs to spotbugs. #432

wants to merge 1 commit into
base: master


Copy link

jeffret-b commented Feb 25, 2020

Demonstrate adding findsecbugs to spotbugs. This commit is a demonstration and is not intended to be merged as-is.

Findsecbugs reports several findings for this plugin, but all of them can be safely suppressed. There are a few that could be a concern, but examination shows that as currently used they do not introduce a vulnerability. While the MD5 usage here is used for tracking and not security, this serves a reminder that it would be better to migrate to a better algorithm. See JENKINS-60563.

This also uses the exclude file for a couple of finding types that are fairly common in Jenkins but not considered a concern.

My plan is to add findsecbugs at the plugin pom after sufficient testing and communication. At that point, it would make sense to add the suppressions, but not the pom file changes from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.