Skip to content
Permalink
Browse files
Fix JENKINS-20198
Removed override of newInstance for EmailTriggerDescriptor. It's not needed because the email triggers should have DataBoundConstructor annotations. The new BindingInterceptor in hudson.model.Descriptor caused an issue with the newInstance method.
  • Loading branch information
slide committed Oct 25, 2013
1 parent 05c5dd6 commit 15832cbb4686122fd43d30af0104b970f43339a5
Showing with 0 additions and 16 deletions.
  1. +0 −16 src/main/java/hudson/plugins/emailext/plugins/EmailTriggerDescriptor.java
@@ -44,20 +44,4 @@ public boolean getDefaultSendToRequester() {
public boolean getDefaultSendToCulprits() {
return false;
}

/**
* Default implementation just creates a new instance of the
* trigger class and returns that.
*/
@Override
public EmailTrigger newInstance(StaplerRequest req, JSONObject formData) {
EmailTrigger res = null;
try {
res = clazz.newInstance();
res.configure(req, formData);
} catch(Exception e) {
// should do something here?
}
return res;
}
}

0 comments on commit 15832cb

Please sign in to comment.