From a82a1c9b2bbd9edd4fba78f95f012d8efe494a04 Mon Sep 17 00:00:00 2001 From: slide Date: Thu, 19 Jul 2012 21:37:53 -0700 Subject: [PATCH] Fix JENKINS-14500 - Added a check to see if there are ANY failures, if not then don't send an improvement email. --- .../emailext/plugins/trigger/ImprovementTrigger.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger.java b/src/main/java/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger.java index 7a9c95139..bc4664dfd 100644 --- a/src/main/java/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger.java +++ b/src/main/java/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger.java @@ -17,12 +17,14 @@ public boolean trigger(AbstractBuild build) { if (build.getPreviousBuild().getTestResultAction() == null) return false; + int numCurrFailures = getNumFailures(build); + // The first part of the condition avoids accidental triggering for // builds that aggregate downstream test results before those test // results are available... return build.getTestResultAction().getTotalCount() > 0 && - getNumFailures(build) < - getNumFailures(build.getPreviousBuild()); + numCurrFailures < getNumFailures(build.getPreviousBuild()) && + numCurrFailures > 0; } @Override