Permalink
2 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Fix JENKINS-28212
Serialize the descriptor id's instead of the descriptors themselves.
- Loading branch information
Showing
with
34 additions
and 25 deletions.
- +2 −2 src/main/java/hudson/plugins/emailext/EmailRecipientUtils.java
- +28 −18 src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java
- +3 −4 src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/config.groovy
- +1 −1 src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/global.groovy
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faac7b4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to say this is still pretty odd. I would expect
defaultTriggers
to be aList<EmailTrigger>
, rather than relying oncreateDefault()
.faac7b4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a reason I didn't do it that way, but I don't remember what it was. I have to have a createDefault at some level though because the triggers themselves can have a different constructor for additional UI elements. So, I can't just call the constructor with known parameters, especially since other plugins can provide EmailTrigger implementations via Extensions.