Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Parent POM + facelift #12

Merged
merged 3 commits into from Oct 6, 2017

Conversation

Projects
None yet
3 participants
@oleg-nenashev
Copy link
Member

oleg-nenashev commented Oct 6, 2017

Just an update towards the next release.

  • - Update Parent POM to 1.39
  • - Fix Upper Bounds issues
  • - Fix issues reported by FindBugs

Snapshot: 1.26-20171006.214254-1

Downstream PRs:

oleg-nenashev added some commits Oct 6, 2017

Resolve Upper Bounds dependencies.
I had to update the baseline to the level of EnvInject API Plugin, which should be fine.
@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

oleg-nenashev commented Oct 6, 2017

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Oct 6, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@@ -166,11 +166,6 @@ public String transformEntry(String key, String value) {
return null;
}

Job<?, ?> project = build.getParent();

This comment has been minimized.

Copy link
@dwnusbaum

dwnusbaum Oct 6, 2017

Member

Is build.getParent guaranteed to be non-null? If so the condition in getEnvMap shouldn't check if it is null either.

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Oct 6, 2017

Author Member

Javadoc says so...
If you have any concerns, I can revert this change and suppress FindBugs. This is a deprecated code anyway

This comment has been minimized.

Copy link
@dwnusbaum

dwnusbaum Oct 6, 2017

Member

No this is good, I just mean that #11 added code that checks if it is null, so can you remove that check there? Line 108 of EnvInjectAction.java. Not sure why FindBugs isn't catching that one.

@dwnusbaum

This comment has been minimized.

Copy link
Member

dwnusbaum commented Oct 6, 2017

🐝

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

oleg-nenashev commented Oct 6, 2017

@reviewbybees done
🚢 🇮🇹

@oleg-nenashev oleg-nenashev merged commit a2397c8 into jenkinsci:master Oct 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.