Skip to content
Permalink
Browse files

[FIX JENKINS-27496] reconfigure may return null

  • Loading branch information
ndeloof committed Mar 18, 2015
1 parent c415857 commit b78c45cc336b2875ca7e4da4c25c95c2235a4e1c
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/main/java/org/jenkinsci/plugins/envinject/EnvInjectJobProperty.java
@@ -132,7 +132,7 @@ public void setContributors(EnvInjectJobPropertyContributor[] jobPropertyContrib
@Override
public JobProperty<?> reconfigure(StaplerRequest req, JSONObject form) throws Descriptor.FormException {
EnvInjectJobProperty property = (EnvInjectJobProperty) super.reconfigure(req, form);
if (property.info != null && !Jenkins.getInstance().hasPermission(Jenkins.RUN_SCRIPTS)) {
if (property != null && property.info != null && !Jenkins.getInstance().hasPermission(Jenkins.RUN_SCRIPTS)) {
// Don't let non RUN_SCRIPT users set arbitrary groovy script
property.info = new EnvInjectJobPropertyInfo(property.info.propertiesFilePath, property.info.propertiesContent,
property.info.getScriptFilePath(), property.info.getScriptContent(),

6 comments on commit b78c45c

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev replied Mar 18, 2015

@ndeloof
Seems #43 is not required anymore :)

@ndeloof

This comment has been minimized.

Copy link
Member Author

ndeloof replied Mar 18, 2015

oh indeed, I didn't noticed a PR existed - just edited directly under github for this minor fix

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev replied Mar 18, 2015

No problem :)
Seems there's a need in a new release (1.91.2?) in any case.

@z0rc

This comment has been minimized.

Copy link

z0rc replied Apr 9, 2015

Any news about the new release? I need this fix too.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev replied Apr 9, 2015

@z0rc
Igor, thanks for the reminder. I've released the new version; it should become available within several hours.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev replied Apr 14, 2015

I had to release the version again (just a common glitch with the old mvn-release plugin version). Everything should be fine now

Please sign in to comment.
You can’t perform that action at this time.