Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-36237] - Improve diagnostics of issues in EnvInjectBuildWrapper#setUp #105

Merged
merged 2 commits into from Sep 26, 2016

Conversation

Projects
None yet
3 participants
@oleg-nenashev
Copy link
Member

commented Sep 25, 2016

Now EnvInjectBuildWrapper#setUp() provides more info in the build log and also forwards stacktrace to the system log. In addition, we rethrow Errors since we cannot recover from them.

https://issues.jenkins-ci.org/browse/JENKINS-36237

@reviewbybees @jenkinsci/code-reviewers

[JENKINS-36237] - Improve diagnostics of issues in EnvInjectBuildWrapper
Now EnvInjectBuildWrapper#setUp() provides more info in the build log and also forwards stacktrace to the system log.
In addition, we rethrow Errors since we cannot recover from them

@oleg-nenashev oleg-nenashev changed the title [JENKINS-36237] - Improve diagnostics of issues in EnvInjectBuildWrapper [JENKINS-36237] - Improve diagnostics of issues in EnvInjectBuildWrapper#setUp Sep 25, 2016

@reviewbybees

This comment has been minimized.

Copy link

commented Sep 25, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Merge branch 'master' into bug/JENKINS-36237
Conflicts:
	src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildWrapper.java
@imod

This comment has been minimized.

Copy link
Member

commented Sep 26, 2016

👍

@oleg-nenashev oleg-nenashev merged commit a898912 into jenkinsci:master Sep 26, 2016

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.