Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-16316] Changes to global variables not honored. #20

Merged
merged 1 commit into from Jul 28, 2013

Conversation

Projects
None yet
5 participants
@jglick
Copy link
Member

commented Jul 26, 2013

Seems to fix JENKINS-16316. When EnvInjectComputerListener.onOnline considers Jenkins.globalNodeProperties, it takes the initial values of these variables and stuffs them into masterEnvVars on the slave, which really ought to be limited to “natural” environment variables. Then when these variables are changed and a build runs, the old values from masterEnvVars take precedence. This is true even if the user has never done anything with the EnvInject plugin except install it—especially insidious.

Pull #14 also claims to fix the same bug, in a very different way. Even if that is rejected, its tests may be useful.

@buildhive

This comment has been minimized.

Copy link

commented Jul 26, 2013

Jenkins » envinject-plugin #104 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Jul 27, 2013

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

gboissinot added a commit that referenced this pull request Jul 28, 2013

Merge pull request #20 from jglick/sticky-var-JENKINS-16316
[JENKINS-16316] Changes to global variables not honored.

@gboissinot gboissinot merged commit 3371ed7 into jenkinsci:master Jul 28, 2013

@jglick jglick deleted the jglick:sticky-var-JENKINS-16316 branch Jul 29, 2013

@sschuberth

This comment has been minimized.

Copy link

commented on dedee19 Jan 15, 2015

@jglick, can this by any chance be the cause for this bug?

@jglick

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2015

Could be. Use git bisect to see. If so, mark JENKINS-18297 as blocking JENKINS-16316. Obviously more complete functional tests are needed for this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.