Skip to content
Permalink
Browse files
[JENKINS-49017][JENKINS-49210] Allow to run tests against latest cores
* This change allows us to run "mvn test -Djenkins.version=2.102 -Djava.level=8" to test compatibility with JEP-200
  • Loading branch information
ikedam committed Jan 27, 2018
1 parent e8393e1 commit 510132ee60ed0e7ee5dc1083035dccc76ab0bcbc
@@ -3,7 +3,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>2.25</version>
<version>2.37</version>
</parent>

<groupId>jp.ikedam.jenkins.plugins</groupId>
@@ -94,7 +94,7 @@ protected void onQueueing(Task p, List<Action> actions)
ExtensibleChoiceParameterDefinition choiceDef = (ExtensibleChoiceParameterDefinition)def;
if(choiceDef.getChoiceListProvider() != null)
{
choiceDef.getChoiceListProvider().onBuildTriggeredWithValue(job, choiceDef, value.value);
choiceDef.getChoiceListProvider().onBuildTriggeredWithValue(job, choiceDef, value.getValue().toString());
}
}
}
@@ -67,7 +67,7 @@ public void onFinalized(AbstractBuild<?,?> build)
ExtensibleChoiceParameterDefinition choiceDef = (ExtensibleChoiceParameterDefinition)def;
if(choiceDef.getChoiceListProvider() != null)
{
choiceDef.getChoiceListProvider().onBuildCompletedWithValue(build, choiceDef, value.value);
choiceDef.getChoiceListProvider().onBuildCompletedWithValue(build, choiceDef, value.getValue().toString());
}
}
}
@@ -395,12 +395,12 @@ public ExtensibleChoiceParameterDefinition(String name, ChoiceListProvider choic
*/
protected ParameterValue createValueCommon(StringParameterValue value)
{
if(!isEditable() && !getChoiceList().contains(value.value))
if(!isEditable() && !getChoiceList().contains(value.getValue()))
{
// Something strange!: Not editable and specified a value not in the choices.
throw new IllegalArgumentException(String.format(
"Illegal choice '%s' in parameter '%s'",
value.value,
value.getValue(),
value.getName()
));
}

0 comments on commit 510132e

Please sign in to comment.