Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-22316] Show candidates based on input value #35

Closed

Conversation

Projects
None yet
2 participants
@cupsadarius
Copy link

commented Feb 4, 2018

Show the dropdown candidates based on the inputed value in editable selects thus providing some sort of autocomplete functionality.

cupsadarius added some commits Feb 4, 2018

@ikedam
Copy link
Member

left a comment

The code looks good, but the code comment looks wrong.
Please update it.

* Changed behavior : Show all the candidates, not concerning with the current incomplete input.
* Changes from the original 4:
* Original behavior: Show all the candidates, not concerning with the current incomplete input.
* Changed behavior : Show candidates that matches the current incomplete input.

This comment has been minimized.

Copy link
@ikedam

ikedam Feb 6, 2018

Member

The "original"means the combobox widget provided by Jenkins core.
https://github.com/jenkinsci/jenkins/blob/jenkins-2.89.3/core/src/main/resources/lib/form/combobox/combobox.js

The number of "Changes from the original" is an ordinal one, and you shouldn't change it.

This comment has been minimized.

Copy link
@cupsadarius

cupsadarius Feb 6, 2018

Author

should i then revert the change number and update the commit?

@ikedam ikedam changed the title Show candidates based on input value [JENKINS-22316] Show candidates based on input value Feb 6, 2018

@ikedam

This comment has been minimized.

Copy link
Member

commented Feb 6, 2018

@ikedam

This comment has been minimized.

Copy link
Member

commented Feb 13, 2018

@cupsadarius

Hmm...
I created #36 , updating the code comment so that it explains the changes from <f:combobox>.
Would you review that?

@ikedam

This comment has been minimized.

Copy link
Member

commented Feb 18, 2018

Merged as #36.

@ikedam ikedam closed this Feb 18, 2018

@ikedam

This comment has been minimized.

Copy link
Member

commented Mar 17, 2018

@cupsadarius Sorry for having you wait for long time.
I released this change as extensible-choice-parameter-1.5.0.
It will be available in the update center in a day.

@cupsadarius

This comment has been minimized.

Copy link
Author

commented Mar 17, 2018

@ikedam no problem! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.