Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-36875] Empty screen when creating new jobs #14

Merged
merged 3 commits into from Jul 26, 2016

Conversation

Projects
None yet
5 participants
@recena
Copy link
Collaborator

commented Jul 22, 2016

JENKINS-36875

There is an enconding issue.

@reviewbybees especially @aheritier

@reviewbybees

This comment has been minimized.

Copy link

commented Jul 22, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@aheritier

This comment has been minimized.

Copy link
Member

commented Jul 22, 2016

Here is what I propose ( I cannot edit your PR)

ExternalJob.displayName=T\u00E2che externe
ExternalJob.Description=Ce type de t\u00E2che permet de suivre l''\u00E9xecution d''un process lanc\u00E9 en dehors de Jenkins, et ce, m\u00EAme sur une machine distante. \
Cela vous permet d'utiliser Jenkins comme tableau de bord de vos syst\u00E8mes automatis\u00E9s existant.\
cf <a href="http://wiki.jenkins-ci.org/display/JENKINS/Monitoring+external+jobs">la documentation pour plus de d\u00E9tails</a>.
@aheritier

This comment has been minimized.

Copy link
Member

commented Jul 22, 2016

cc @batmat @alecharp and the french connection

@recena

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 22, 2016

A preview:

jenkins-36875

@recena

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 22, 2016

@aheritier I recommend to remove the link, I did that in the spanish translation. I don't like the idea about including HTML code in property file entries. In fact, the links are not working 😭

@recena recena force-pushed the recena:JENKINS-36875 branch from 3154f96 to f6297d5 Jul 22, 2016

@aheritier

This comment has been minimized.

Copy link
Member

commented Jul 22, 2016

ok @recena In that case we need to remove it from the EN version (this is where I copied it)

@recena recena force-pushed the recena:JENKINS-36875 branch from 9c2bfe2 to f4283b1 Jul 22, 2016

@recena

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 22, 2016

@aheritier and @jenkinsci/code-reviewers, What do you think?

@daniel-beck

This comment has been minimized.

Copy link
Member

commented Jul 22, 2016

To clarify, no links in item type descriptions work due to the chosen UI behavior? I.e. clicking the "link" will just select the item type?

@recena

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 24, 2016

@daniel-beck No. You can add links in the item description but it seems the current implementation does not allow to click the links becasue the event is being handled by a specific function. I have to review it.

At any rate, I don't recommend to include HTML code in the item description.

@aheritier

This comment has been minimized.

Copy link
Member

commented Jul 25, 2016

@recena Let's track this problem of link somewhere else but yes for now I prefer no link than a broken link (especialy if the problem comes from the Core/UI and not the plugin).

@recena

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 26, 2016

@aheritier It seems it is confirmed that this PR works.

@aheritier

This comment has been minimized.

Copy link
Member

commented Jul 26, 2016

yes @recena
Let's merge/release I think to have a quick fix ASAP (even if it should - for now - consider only few people)

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Jul 26, 2016

👍 BTW

@aheritier

This comment has been minimized.

Copy link
Member

commented Jul 26, 2016

🐝

@recena recena merged commit f40d71f into jenkinsci:master Jul 26, 2016

1 check passed

Jenkins This pull request looks good
Details

@recena recena deleted the recena:JENKINS-36875 branch Jul 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.