New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various tweaks and fixes #14
Conversation
Conflicts: src/main/resources/hudson/plugins/fitnesse/ResultsDetails/body.jelly
Conflicts: pom.xml
Conflicts: pom.xml
Initial project configuration based on the parameters is next up
plugins » fitnesse-plugin #25 FAILURE |
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
Looks like there was a merge conflict. Would you mind taking a look as you are most familiar with your changes? |
I'd be happy to - could you take a peek and see which changes you'd actually be interested in? Then I'll apply those to latest HEAD. |
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | ||
<modelVersion>4.0.0</modelVersion> | ||
<parent> | ||
<groupId>org.jenkins-ci.plugins</groupId> | ||
<artifactId>plugin</artifactId> | ||
<version>1.420</version> | ||
<version>1.512</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this absolutely necessary? I remember doing something similar when I first committed and was corrected by some senior Jenkins devs that it is best to use the oldest version that supports your features.
I don't see why we can't keep it all. I'd hate to waste your efforts. Overall it looks good. |
6848a69
to
541f4bb
Compare
9eae966
to
c36b564
Compare
1b35131
to
c36b564
Compare
merged in PR #23 |
A grab-bag of some improvements, including a 'history' view showing FitNesse results from all history builds and a FitNesse 'project type' to more easily start setting up a FitNesse-based Jenkins job.