Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various tweaks and fixes #14

Closed
wants to merge 18 commits into from
Closed

Various tweaks and fixes #14

wants to merge 18 commits into from

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Jun 26, 2014

A grab-bag of some improvements, including a 'history' view showing FitNesse results from all history builds and a FitNesse 'project type' to more easily start setting up a FitNesse-based Jenkins job.

@cloudbees-pull-request-builder

plugins » fitnesse-plugin #25 FAILURE
Looks like there's a problem with this pull request

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@lessonz
Copy link
Member

lessonz commented Jun 27, 2014

Looks like there was a merge conflict. Would you mind taking a look as you are most familiar with your changes?

@raboof
Copy link
Contributor Author

raboof commented Jun 28, 2014

I'd be happy to - could you take a peek and see which changes you'd actually be interested in? Then I'll apply those to latest HEAD.

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>1.420</version>
<version>1.512</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this absolutely necessary? I remember doing something similar when I first committed and was corrected by some senior Jenkins devs that it is best to use the oldest version that supports your features.

@lessonz
Copy link
Member

lessonz commented Jul 1, 2014

I don't see why we can't keep it all. I'd hate to waste your efforts. Overall it looks good.

@antoine-aumjaud
Copy link
Contributor

merged in PR #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants