Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable JDK for Fitnesse #3

Merged
merged 5 commits into from Aug 22, 2012

Conversation

Projects
None yet
3 participants
@dpisechko
Copy link
Contributor

dpisechko commented Aug 22, 2012

I have enhanced your plugin to allow the user to configure the JDK to use when running Fitnesse. The plugin provides a dropdown of Jenkins installed JDKs, unless only one is installed, in which case the default is used. This will override the java executable which is used to invoke Fitnesse.

We have found this useful in the case that we must develop and compile against Java 5 while we want to acceptance test with the latest versions of Fitnesse which require Java 6.

Please note that at the time I forked and implemented this, there were 3 unit tests failing and several tests commented out. I have added a few unit tests around the new functionality and have not introduced any new failures.

@buildhive

This comment has been minimized.

Copy link

buildhive commented Aug 22, 2012

Jenkins » fitnesse-plugin #8 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

swestcott added a commit that referenced this pull request Aug 22, 2012

Merge pull request #3 from Honesty-Box/master
Selectable JDK for Fitnesse

@swestcott swestcott merged commit 2e42015 into jenkinsci:master Aug 22, 2012

@swestcott

This comment has been minimized.

@swestcott

This comment has been minimized.

Copy link
Contributor

swestcott commented Aug 23, 2012

When merged with master, there's a new NPE coming from this change inside FitnesseExecutor::getJavaCmd. Could look into this?

Full stack trace @ https://buildhive.cloudbees.com/job/jenkinsci/job/fitnesse-plugin/org.jenkins-ci.plugins$fitnesse/10/testReport/junit/hudson.plugins.fitnesse/FitnesseExecutorTest/javaCmdShouldReferenceFitnesseSpecificJavaHome/

@dpisechko

This comment has been minimized.

Copy link
Contributor Author

dpisechko commented Aug 23, 2012

Will be looked into when time allows, thanks for the use of a great plugin!

On Thu, Aug 23, 2012 at 2:33 AM, Si Westcott notifications@github.comwrote:

When merged with master, there's a new NPE coming from this change inside
FitnesseExecutor::getJavaCmd. Could look into this?

Full stack trace @
https://buildhive.cloudbees.com/job/jenkinsci/job/fitnesse-plugin/org.jenkins-ci.plugins$fitnesse/10/testReport/junit/hudson.plugins.fitnesse/FitnesseExecutorTest/javaCmdShouldReferenceFitnesseSpecificJavaHome/


Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-7962101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.