Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Selectable JDK for Fitnesse #3
I have enhanced your plugin to allow the user to configure the JDK to use when running Fitnesse. The plugin provides a dropdown of Jenkins installed JDKs, unless only one is installed, in which case the default is used. This will override the java executable which is used to invoke Fitnesse.
We have found this useful in the case that we must develop and compile against Java 5 while we want to acceptance test with the latest versions of Fitnesse which require Java 6.
Please note that at the time I forked and implemented this, there were 3 unit tests failing and several tests commented out. I have added a few unit tests around the new functionality and have not introduced any new failures.
added a commit
this pull request
Aug 22, 2012
When merged with master, there's a new NPE coming from this change inside FitnesseExecutor::getJavaCmd. Could look into this?
Full stack trace @ https://buildhive.cloudbees.com/job/jenkinsci/job/fitnesse-plugin/org.jenkins-ci.plugins$fitnesse/10/testReport/junit/hudson.plugins.fitnesse/FitnesseExecutorTest/javaCmdShouldReferenceFitnesseSpecificJavaHome/
Will be looked into when time allows, thanks for the use of a great plugin!
On Thu, Aug 23, 2012 at 2:33 AM, Si Westcott firstname.lastname@example.org: