Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pipeline compatibility #30

Merged
merged 11 commits into from Nov 30, 2016

Conversation

Projects
None yet
6 participants
@raymondwu1
Copy link
Contributor

raymondwu1 commented Nov 30, 2016

Adds pipeline compatibility to the Fitnesse plugin
Thanks to eplatti for fixing the findbugs issues

@lessonz lessonz merged commit a6c6f43 into jenkinsci:master Nov 30, 2016

1 check passed

Jenkins This pull request looks good
Details

@raymondwu1 raymondwu1 deleted the raymondwu1:feature/pipelineCompatibility branch Nov 30, 2016

@raymondwu1 raymondwu1 restored the raymondwu1:feature/pipelineCompatibility branch Nov 30, 2016

@childnode

This comment has been minimized.

Copy link

childnode commented Jun 13, 2017

unfortunatly this code has not been published yet : https://issues.jenkins-ci.org/browse/JENKINS-41514 > https://issues.jenkins-ci.org/browse/JENKINS-40165
pom points out version 1.22, last tag is 1.16, last publication on https://plugins.jenkins.io/fitnesse 2 years ago at 1.16

https://github.com/jenkinsci/pipeline-plugin/blob/master/COMPATIBILITY.md hasn't been updated neither

Code changes only adresses compatible code so the step can be used as a generic task as like

step([
  $class: 'FitnesseResultsRecorder',
  fitnessePathToXmlResultsIn: '*.xml'
])

but it doesn't address the DSL as far I can see

@lessonz

This comment has been minimized.

Copy link
Member

lessonz commented Jun 13, 2017

Unfortunately, I haven't used FitNesse in years. If someone would like to request commit access, you're welcome to do so. I did the same myself years ago because I needed a fix for this repo. Unfortunately, a quick search doesn't turn up the link for requesting that access. The wiki lists timbacon as the maintainer, and maybe that's true.

If you're interested and motivated, I welcome you to request committer access so you can handle pushing a new release. In 2014, it looks like I did that via the maven-release-plugin. I wish you the best of luck.

@jaruzafa

This comment has been minimized.

Copy link
Contributor

jaruzafa commented Sep 24, 2018

Hi @lessonz ,
I really need this feature for my pipeline. Please, could you give me commit acces so I can release a new version?
Thanks!

@lessonz

This comment has been minimized.

Copy link
Member

lessonz commented Sep 24, 2018

@jaruzafa First, to get you unblocked, I suggest you build a local copy and install it. I've done this myself in the past.

Second, I am no longer involved with this plugin, please see: https://groups.google.com/forum/#!topic/jenkinsci-dev/II-ishc_xfU

I do not have permissions to grant any rights on this repo. I haven't used FitNesse in years. I'm sorry I couldn't be more help.

@jaruzafa jaruzafa referenced this pull request Oct 18, 2018

Merged

Added myself as a developer for Fitnesse plugin #895

4 of 4 tasks complete
@muriloht

This comment has been minimized.

Copy link

muriloht commented Feb 12, 2019

hi @jaruzafa do you have some sample of how you did your fitnesse run into your pipeline? tks!

@jaruzafa

This comment has been minimized.

Copy link
Contributor

jaruzafa commented Feb 12, 2019

Sure!
You can use the Pipeline Syntax helper to generate the commands. Go to Pipeline Syntax -> Step: General Build Step -> Execute Fitnesse tests and PublishFitNesse Results.

Example:
Executing your suite:

step([$class: 'FitnesseBuilder', options: [fitnessePathToRoot: 'fitnesse/FitNesseRoot', additionalFitnesseOptions: '', fitnesseTestTimeout: '', fitnesseStart: 'True', fitnesseHttpTimeout: '', fitnesseTargetIsSuite: 'true', fitnesseJavaOpts: '', fitnessePathToJar: 'fitnesse/fitnesse-standalone.jar', fitnesseTargetPage: 'MyTestSuite', fitnessePathToXmlResultsOut: 'results.xml', fitnessePortLocal: '8080', fitnesseJavaWorkingDirectory: '']]) 

Publishing the results:

step([$class: 'FitnesseResultsRecorder', fitnessePathToXmlResultsIn: 'results.xml'])
@muriloht

This comment has been minimized.

Copy link

muriloht commented Feb 12, 2019

Thank you @jaruzafa ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.