Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for JEP-200 #35

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
5 participants
@CSLTech
Copy link

CSLTech commented Mar 1, 2018

Simple fixes for JEP-200 compatibility.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Apr 2, 2018

Added the issue to https://wiki.jenkins.io/display/JENKINS/Plugins+affected+by+fix+for+JEP-200. If you see JEP-200 regressions, please report them according to these guidelines so that JEP-200 maintainers get notification about the defect. We do not monitor GitHub pull requests.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Apr 2, 2018

@lessonz are you the current plugin's maintainer? If yes, a review/release would be appreciated. This issue complicates usage of the plugin with Jenkins 2.102+

@oleg-nenashev oleg-nenashev referenced this pull request Apr 2, 2018

Merged

Update plugin-fitnesse.yml #653

5 of 9 tasks complete
@lessonz

This comment has been minimized.

Copy link
Member

lessonz commented Apr 2, 2018

@CSLTech is in the process of getting perms for maintaining this plugin.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Apr 2, 2018

Permissions granted. Thanks again @lessonz

@@ -38,7 +38,7 @@
private FitnesseResults parent;
private List<FitnesseResults> details = new ArrayList<FitnesseResults>();
private transient Run<?,?> owner;
private TaskListener listener;
private transient TaskListener listener;

This comment has been minimized.

@jglick

jglick Apr 2, 2018

Member

Generally need to either restore in readResolve, or stop making it an instance field altogether (use a local variable), or access only via a getter which sets it on demand.

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Apr 2, 2018

Member

Right. It would be also reasonable to rename the field at least so that it does not cause deserialization warnings for obsolete data

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Apr 12, 2018

@CSLTech Please let us know if you need any help with the release. You should have all required permissions now

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Apr 24, 2018

@lessonz @CSLTech hi, gentle ping. Let us know if you need any help with the release. JEP-200 maintenance period expires on May 01, and it would be great to minimize the number of leftovers

@CSLTech

This comment has been minimized.

Copy link
Author

CSLTech commented Apr 24, 2018

@oleg-nenashev Things have been hectic around here with a rush to deploy certain features. I have just landed on my feet. I will be publishing the build this week.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Apr 24, 2018

ack, thanks for the update!

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented May 9, 2018

@CSLTech It has not been published yet AFAICT

@daldinger daldinger referenced this pull request Jun 11, 2018

Merged

Feature/junit results #36

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Jul 7, 2018

@CSLTech gentle ping

@jaruzafa jaruzafa merged commit 1d8ebb3 into jenkinsci:master Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.