Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Permit the setting of Build Schedule Delay to "0". Delay not needed with Replication Events #143
When using Replication Events, a build schedule delay is not needed since the build will only start once the replication is complete. This PR removes the minimum value 3 seconds BUT keeps the 3 seconds as the default when no value is entered for Build Schedule Delay.
I haven't pulled and compiled to test, so this is only my opinion based on code reading. The implementation seems good, and provides the "3 second requirement" as part of the dependency extension. This is good as it means the dependency extension does not have expectations on external gerrit-trigger code / behaviour. Also, I think it is nice, since it only enforces this 3 second queuing for projects with dependencies, others may start immediately, so it's a definite improvement overall.
On a side-note: I used "dependency jobs" for "upstream jobs" and "dependent jobs" for "downstream jobs", this latest patch does not, but I think it's not an issue. Moreover, since this naming convention was not very explicit, I only blame myself :) There's a definite vocab issue in English to distinguish between the upstream dependency and the downstream dependent.