Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get gerrit events from RabbitMQ as message queue service #151

Merged
merged 1 commit into from May 5, 2014

Conversation

Projects
None yet
4 participants
@rinrinne
Copy link
Member

commented May 1, 2014

This patch adds implementation of MessageQueueListener extension in
RabbitMQ Consumer Plugin.

https://wiki.jenkins-ci.org/display/JENKINS/RabbitMQ+Consumer+Plugin

Using this feature, we can trigger job by gerrit event in message queue.

At first, I had plan to release this as independent plugin. But after some study,
I concluded that it should be implemented to this plugin.

  • Very simple code
  • Optional flags to ignore NoClassDefException related to other plugins
    • No impact if those are not installed

So I would be glad if you merge this.

Get gerrit events from RabbitMQ as message queue service
This patch adds implementation of MessageQueueListener extension in
RabbitMQ Consumer Plugin.

https://wiki.jenkins-ci.org/display/JENKINS/RabbitMQ+Consumer+Plugin

Using this feature, we can trigger job by gerrit event in message queue.
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented May 1, 2014

plugins » gerrit-trigger-plugin #252 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented May 1, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@rsandell

This comment has been minimized.

Copy link
Member

commented May 5, 2014

Wouldn't it be cool if the Trigger in the future could send back the code review result to the MQ as well? Perhaps via a "special" GerritServer implementation, but it would require quite a lot of refactoring in the notifier parts of the plugin. Still I think it would be useful.

rsandell added a commit that referenced this pull request May 5, 2014

Merge pull request #151 from rinrinne/rabbitmq
Get gerrit events from RabbitMQ as message queue service

@rsandell rsandell merged commit 96e43f2 into jenkinsci:master May 5, 2014

@rinrinne

This comment has been minimized.

Copy link
Member Author

commented May 12, 2014

Thanks for merging!

Yes, I have plan to send result via MQ. But I think migration to REST API is prior to it. So I guess MQ support for sending will be implemented after version 3 of this plugin :)
(RabbitMQ Consumer Plugin already has simple interface for sending. But test is not enough...)

As a practical matter, I still not investigate whether gerrit plugin can implement it or not. (Certainly, it can be done by establishing bypass service, but seems they don't like such solution...)

BTW, I cannot see beta release on package manager and plugin wiki's header table, but I confirmed that it already exists in repository. How to test it? (I could do by getting it directly then installing manually.)

@rsandell

This comment has been minimized.

Copy link
Member

commented May 13, 2014

@rinrinne

This comment has been minimized.

Copy link
Member Author

commented May 13, 2014

I can find it using experimental feed! Thanks!

@rinrinne rinrinne deleted the rinrinne:rabbitmq branch Nov 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.