Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for review notification levels #152

Merged
merged 2 commits into from May 20, 2014

Conversation

Projects
None yet
4 participants
@chgeo
Copy link
Contributor

commented May 9, 2014

This is basically support for Rest API's 'notify' field on ReviewInputs.
as specified in [1].

UI changes

  • Add 'Notification Level' dropdown on GerritServer allowing to
    select one the permitted values. The default is 'ALL', which
    matches to the existing behavior of notifying all interested users.
  • Add 'Notification Level' dropdown on GerritTrigger allowing to
    override the server default.

In case of multiple builds for a Gerrit event, the highest value is
chosen.

[1] https://gerrit-documentation.storage.googleapis.com/Documentation/2.7/rest-api-changes.html#set-review

Support for review notification levels
This is basically support for Rest API's 'notify' field on ReviewInputs.
as specified in [1].

UI changes
* Add 'Notification Level' dropdown on GerritServer allowing to
  select one the permitted values.  The default is 'ALL', which
  matches to the existing behavior of notifying all interested users.
* Add 'Notification Level' dropdown on GerritTrigger allowing to
  override the server default.

In case of multiple builds for a Gerrit event, the highest value is
chosen.

[1] https://gerrit-documentation.storage.googleapis.com/Documentation/2.7/rest-api-changes.html#set-review
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented May 9, 2014

plugins » gerrit-trigger-plugin #257 FAILURE
Looks like there's a problem with this pull request

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented May 9, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented May 19, 2014

plugins » gerrit-trigger-plugin #259 UNSTABLE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented May 19, 2014

plugins » gerrit-trigger-plugin #260 SUCCESS
This pull request looks good

@@ -0,0 +1,4 @@
Defines to whom email notifications should be sent.

This can either be nobody, the change owner, reviewers plus change owner, or all interested users

This comment has been minimized.

Copy link
@rsandell

rsandell May 19, 2014

Member

Should mention that it only applies when using the REST Api

This comment has been minimized.

Copy link
@chgeo

chgeo May 20, 2014

Author Contributor

Done

Support for review notification levels
This is basically support for Rest API's 'notify' field on ReviewInputs.
as specified in [1].

UI changes
* Add 'Notification Level' dropdown on GerritServer allowing to
  select one the permitted values.  The default is 'ALL', which
  matches to the existing behavior of notifying all interested users.
* Add 'Notification Level' dropdown on GerritTrigger allowing to
  override the server default.

In case of multiple builds for a Gerrit event, the highest value is
chosen.

[1] https://gerrit-documentation.storage.googleapis.com/Documentation/2.7/rest-api-changes.html#set-review
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented May 20, 2014

plugins » gerrit-trigger-plugin #261 SUCCESS
This pull request looks good

rsandell added a commit that referenced this pull request May 20, 2014

Merge pull request #152 from chgeo/notify-support
Support for review notification levels

@rsandell rsandell merged commit 4949fb8 into jenkinsci:master May 20, 2014

@chgeo chgeo deleted the chgeo:notify-support branch May 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.