Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to exclude drafts when triggering on patchset created event. #153

Merged
merged 1 commit into from May 26, 2014

Conversation

Projects
None yet
4 participants
@hugares
Copy link
Member

commented May 22, 2014

Gerrit support draft changes and draft patchsets. Gerrit Trigger was able
to trigger a build when a draft change is published (transitioned from draft to
regular change) but it was missing an option to allow user to exclude draft
patchsets when triggering on patchset created event.

This change add a checkbox in the patchset created type of trigger to exclude
draft patchsets. By default, this option is not enabled to be compatible with behaviour
prior to this change.

Add option to exclude drafts when triggering on patchset created event.
Gerrit support draft changes and draft patchsets. Gerrit Trigger was able
to trigger a build when a draft change is published (transitioned from draft to
regular change) but it was missing an option to allow user to exclude draft
patchsets when triggering on patchset created event.

This change add a checkbox in the patchset created type of trigger to exclude
draft patchsets. By default, this option is not enabled to be compatible with behaviour
prior to this change.

Change-Id: I279a34662a46c6aa9657b2b604027b0e52f76adc
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented May 22, 2014

plugins » gerrit-trigger-plugin #264 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented May 22, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@rsandell

This comment has been minimized.

Copy link
Member

commented May 26, 2014

Note to self: The comment added "shouldTriggerOn logic" should probably be moved into its event class as well.

rsandell added a commit that referenced this pull request May 26, 2014

Merge pull request #153 from hugares/excludeDrafts
Add option to exclude drafts when triggering on patchset created event.

@rsandell rsandell merged commit 7a381e9 into jenkinsci:master May 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.