Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent to send plaintext password to browser #158

Merged
merged 2 commits into from Jun 2, 2014

Conversation

Projects
None yet
5 participants
@rinrinne
Copy link
Member

commented May 28, 2014

Fix for JENKINS-23165 and pull #157

Prevent to send plaintext password to browser
Fix for JENKINS-23165 and pull #157
@rinrinne

This comment has been minimized.

Copy link
Member Author

commented May 28, 2014

@jglick Please review.

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented May 28, 2014

plugins » gerrit-trigger-plugin #279 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented May 28, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

gerritAuthKeyFile, gerritUserName, gerritAuthKeyFilePassword.getPlainText());
}
return authentication;
return new Authentication(gerritAuthKeyFile, gerritUserName, Secret.toString(gerritAuthKeyFilePassword));

This comment has been minimized.

Copy link
@jglick

jglick May 28, 2014

Member

Could I guess be simplified to use getGerritAuthKeyFilePassword() here.

} else {
return new UsernamePasswordCredentials(gerritHttpUserName, gerritHttpPassword.getPlainText());
}
return new UsernamePasswordCredentials(gerritHttpUserName, Secret.toString(gerritHttpPassword));

This comment has been minimized.

Copy link
@jglick

jglick May 28, 2014

Member

Similarly could use getGerritHttpPassword() here.

@@ -944,11 +938,7 @@ public void setUseRestApi(boolean useRestApi) {

@Override
public String getGerritHttpPassword() {

This comment has been minimized.

Copy link
@jglick

jglick May 28, 2014

Member

No Secret equivalent to this?

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented May 29, 2014

plugins » gerrit-trigger-plugin #280 SUCCESS
This pull request looks good

rsandell added a commit that referenced this pull request Jun 2, 2014

Merge pull request #158 from rinrinne/pw-on-browser
Prevent to send plaintext password to browser

@rsandell rsandell merged commit 7c44a4a into jenkinsci:master Jun 2, 2014

@rinrinne rinrinne deleted the rinrinne:pw-on-browser branch Aug 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.